starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #11872] [MERGED] Delete RendererTests.cpp #28775

New Issue
Open
opened 2026-01-31 09:30:40 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:30:40 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11872
Author: @j4james
Created: 12/2/2021
Status: ✅ Merged
Merged: 12/3/2021
Merged by: @undefined

Base: main ← Head: nuke-renderertests

📝 Commits (2)

  • 337efa8 Delete unused RendererTests.cpp file.
  • 0ea3e85 Remove unused Renderer::s_CreateInstance methods.

📊 Changes

2 files changed (+0 additions, -79 deletions)

View changed files

➖ src/host/ut_host/RendererTests.cpp (+0 -71)
📝 src/renderer/base/renderer.hpp (+0 -8)

📄 Description

Summary of the Pull Request

This PR gets rids of the unused RendererTests.cpp file and removes
the Renderer::s_CreateInstance method declarations that were only
ever reference from that file, and weren't actually defined anywhere.

PR Checklist

  • Closes Auto display readme`s (#11870)
  • CLA signed.
  • Tests added/passed
  • Documentation updated.
  • Schema updated.
  • I've not discussed this with core contributors already.

Validation Steps Performed

Compiled the solution and ran the tests - everything still worked.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11872 **Author:** [@j4james](https://github.com/j4james) **Created:** 12/2/2021 **Status:** ✅ Merged **Merged:** 12/3/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `nuke-renderertests` --- ### 📝 Commits (2) - [`337efa8`](https://github.com/microsoft/terminal/commit/337efa88cb6d5f4fc37b0993bcfccbc64c695ffa) Delete unused RendererTests.cpp file. - [`0ea3e85`](https://github.com/microsoft/terminal/commit/0ea3e85e1186982a87f747ccc4a26d14f09637d5) Remove unused Renderer::s_CreateInstance methods. ### 📊 Changes **2 files changed** (+0 additions, -79 deletions) <details> <summary>View changed files</summary> ➖ `src/host/ut_host/RendererTests.cpp` (+0 -71) 📝 `src/renderer/base/renderer.hpp` (+0 -8) </details> ### 📄 Description ## Summary of the Pull Request This PR gets rids of the unused `RendererTests.cpp` file and removes the `Renderer::s_CreateInstance` method declarations that were only ever reference from that file, and weren't actually defined anywhere. ## PR Checklist * [x] Closes #11870 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [ ] I've not discussed this with core contributors already. ## Validation Steps Performed Compiled the solution and ran the tests - everything still worked. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:30:40 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28775
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?