[PR #11877] Apply MVVM for profiles in SUI #28779

Open
opened 2026-01-31 09:30:41 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/11877

State: closed
Merged: Yes


Summary of the Pull Request

Cleans up ProfileViewModel, Profiles, and ProfilePageNavigationState to move all of the view model responsibilities over to ProfileViewModel. We don't actually store the ProfilePageNavigationState anymore. We only use it as a way to transfer information to the new page.

References

#9207 - Apply MVVM

Detailed Description of the Pull Request / Additional comments

  • I pulled out ProfileViewModel into its own file to keep things cleaner. It was getting pretty big.
  • The font lists are now stored in a static location in ProfileViewModel, which means that we can reuse the same list between pages.
  • the profile pivot was also moved to the ProfileViewModel and stored as a static value.

Validation Steps Performed

✅ pivot behavior is the same
✅ font list is still populated

**Original Pull Request:** https://github.com/microsoft/terminal/pull/11877 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request Cleans up `ProfileViewModel`, `Profiles`, and `ProfilePageNavigationState` to move all of the view model responsibilities over to `ProfileViewModel`. We don't actually store the `ProfilePageNavigationState` anymore. We only use it as a way to transfer information to the new page. ## References #9207 - Apply MVVM ## Detailed Description of the Pull Request / Additional comments - I pulled out `ProfileViewModel` into its own file to keep things cleaner. It was getting pretty big. - The font lists are now stored in a static location in `ProfileViewModel`, which means that we can reuse the same list between pages. - the profile pivot was also moved to the `ProfileViewModel` and stored as a static value. ## Validation Steps Performed ✅ pivot behavior is the same ✅ font list is still populated
claunia added the pull-request label 2026-01-31 09:30:41 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28779