[PR #11892] [MERGED] Make sure to deserialize arg params _before_ validating #28786

Open
opened 2026-01-31 09:30:44 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11892
Author: @zadjii-msft
Created: 12/7/2021
Status: Merged
Merged: 12/7/2021
Merged by: @undefined

Base: mainHead: dev/migrie/eim/oops-all-berries


📝 Commits (1)

  • 6a56b2a make sure to deserialize before validating

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalSettingsModel/ActionArgsMagic.h (+2 -2)

📄 Description

I had these out of order, and apparently forgot to launch the Terminal before pushing that commit. This resulted in getting the following with the default settings:
image

So yea obviously, we should deserialize first, then check if the setting is valid.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11892 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 12/7/2021 **Status:** ✅ Merged **Merged:** 12/7/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/eim/oops-all-berries` --- ### 📝 Commits (1) - [`6a56b2a`](https://github.com/microsoft/terminal/commit/6a56b2aa9ff24747b1ba9a923e65fbff05c2de57) make sure to deserialize _before_ validating ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsModel/ActionArgsMagic.h` (+2 -2) </details> ### 📄 Description I had these out of order, and apparently forgot to launch the Terminal before pushing that commit. This resulted in getting the following with the default settings: ![image](https://user-images.githubusercontent.com/18356694/145033088-d6483a75-9dfc-4af4-8bf0-0a35b889aeef.png) So yea obviously, we should deserialize first, then check if the setting is valid. * [x] regressed in #11859 * [x] actually tested this time * [x] Closes #11896 * [x] Closes #11895 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:30:44 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28786