[PR #11981] [MERGED] Only look for PGO package if build mode targeted; add packages.config dependency to ease restoration #28815

Open
opened 2026-01-31 09:30:56 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/11981
Author: @miniksa
Created: 12/16/2021
Status: ✅ Merged
Merged: 12/16/2021
Merged by: @undefined

Base: main ← Head: dev/miniksa/nuget_oop


📝 Commits (2)

  • d413ea7 Update nuget references and conditions for PGO package.
  • 1f1523d now that the individual packages require it, the build one doesn't have to

📊 Changes

11 files changed (+13 additions, -3 deletions)

View changed files

📝 build/packages.config (+0 -1)
📝 src/cascadia/Remoting/packages.config (+1 -0)
📝 src/cascadia/TerminalApp/packages.config (+1 -0)
📝 src/cascadia/TerminalConnection/packages.config (+1 -0)
📝 src/cascadia/TerminalControl/packages.config (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/packages.config (+1 -0)
📝 src/cascadia/TerminalSettingsModel/packages.config (+1 -0)
📝 src/cascadia/WindowsTerminal/packages.config (+1 -0)
📝 src/common.build.post.props (+1 -1)
📝 src/common.build.pre.props (+1 -1)
➕ src/host/exe/packages.config (+4 -0)

📄 Description

Only look for PGO package if build mode targeted; add packages.config dependency to ease restoration

PR Checklist


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/11981 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 12/16/2021 **Status:** ✅ Merged **Merged:** 12/16/2021 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/miniksa/nuget_oop` --- ### 📝 Commits (2) - [`d413ea7`](https://github.com/microsoft/terminal/commit/d413ea7db9e95062303a71dbbba2ad5900dfe917) Update nuget references and conditions for PGO package. - [`1f1523d`](https://github.com/microsoft/terminal/commit/1f1523ddd3815b50ac0e30c00f4a72997f727d81) now that the individual packages require it, the build one doesn't have to ### 📊 Changes **11 files changed** (+13 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `build/packages.config` (+0 -1) 📝 `src/cascadia/Remoting/packages.config` (+1 -0) 📝 `src/cascadia/TerminalApp/packages.config` (+1 -0) 📝 `src/cascadia/TerminalConnection/packages.config` (+1 -0) 📝 `src/cascadia/TerminalControl/packages.config` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/packages.config` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/packages.config` (+1 -0) 📝 `src/cascadia/WindowsTerminal/packages.config` (+1 -0) 📝 `src/common.build.post.props` (+1 -1) 📝 `src/common.build.pre.props` (+1 -1) ➕ `src/host/exe/packages.config` (+4 -0) </details> ### 📄 Description Only look for PGO package if build mode targeted; add packages.config dependency to ease restoration ## PR Checklist * [x] Closes #11978 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [x] Test of restore and build on fresh repo copy passed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:30:56 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28815