starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12089] [MERGED] Colortool: improve color table. #28824

New Issue
Open
opened 2026-01-31 09:31:00 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:31:00 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12089
Author: @LuanVSO
Created: 1/4/2022
Status: ✅ Merged
Merged: 1/11/2022
Merged by: @undefined

Base: main ← Head: colortool-table

📝 Commits (7)

  • bce89f7 Colortool: improve color table.
  • 6a2f152 colortool: make extended color table optional
  • 810db61 colortool: fix wrong colors being used
  • c7fed33 colortool: turn on vt mode before printing tb
  • 3eb606a Colortool: update help text on readme
  • 001e057 add "allcolors" to spell checker allow list
  • 92feda4 Merge branch 'main' into colortool-table

📊 Changes

10 files changed (+130 additions, -124 deletions)

View changed files

📝 .github/actions/spelling/allow/allow.txt (+1 -0)
📝 src/tools/ColorTool/ColorTool/ColorTable.cs (+64 -71)
📝 src/tools/ColorTool/ColorTool/ConsoleTargets/CurrentConsoleTarget.cs (+2 -2)
📝 src/tools/ColorTool/ColorTool/ConsoleTargets/DefaultConsoleTarget.cs (+1 -1)
📝 src/tools/ColorTool/ColorTool/ConsoleTargets/IConsoleTarget.cs (+1 -1)
📝 src/tools/ColorTool/ColorTool/ConsoleTargets/TerminalSchemeConsoleTarget.cs (+1 -1)
📝 src/tools/ColorTool/ColorTool/ConsoleTargets/VirtualTerminalConsoleTarget.cs (+2 -3)
📝 src/tools/ColorTool/ColorTool/Program.cs (+25 -13)
📝 src/tools/ColorTool/ColorTool/Resources.resx (+32 -32)
📝 src/tools/ColorTool/README.md (+1 -0)

📄 Description

Summary of the Pull Request

  • add suport for light backgrounds
  • make color tool use 90-97 and 100-107 sequences for fg/bg
  • fix loops stop condition

References

PR Checklist

  • CLA signed. If not, go over here and sign the CLA
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments

additional improvements that I've seen while working on #12087

Validation Steps Performed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12089 **Author:** [@LuanVSO](https://github.com/LuanVSO) **Created:** 1/4/2022 **Status:** ✅ Merged **Merged:** 1/11/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `colortool-table` --- ### 📝 Commits (7) - [`bce89f7`](https://github.com/microsoft/terminal/commit/bce89f7cf48d0f26bdaefa457249aa174933b7a7) Colortool: improve color table. - [`6a2f152`](https://github.com/microsoft/terminal/commit/6a2f15202385e4dae6f994df8aaaea4382e41f1d) colortool: make extended color table optional - [`810db61`](https://github.com/microsoft/terminal/commit/810db619c21a0ee96b8dca85cf8256644bfaa671) colortool: fix wrong colors being used - [`c7fed33`](https://github.com/microsoft/terminal/commit/c7fed337edd60f17f27ae189541b1173490f3bfc) colortool: turn on vt mode before printing tb - [`3eb606a`](https://github.com/microsoft/terminal/commit/3eb606a8fb31682e1ad8ef3f97799a9b66fdf7ef) Colortool: update help text on readme - [`001e057`](https://github.com/microsoft/terminal/commit/001e057bec3903a053d21427ff0e7dce84380b76) add "allcolors" to spell checker allow list - [`92feda4`](https://github.com/microsoft/terminal/commit/92feda4fec925adec63a5fc72e283143a3379700) Merge branch 'main' into colortool-table ### 📊 Changes **10 files changed** (+130 additions, -124 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/allow.txt` (+1 -0) 📝 `src/tools/ColorTool/ColorTool/ColorTable.cs` (+64 -71) 📝 `src/tools/ColorTool/ColorTool/ConsoleTargets/CurrentConsoleTarget.cs` (+2 -2) 📝 `src/tools/ColorTool/ColorTool/ConsoleTargets/DefaultConsoleTarget.cs` (+1 -1) 📝 `src/tools/ColorTool/ColorTool/ConsoleTargets/IConsoleTarget.cs` (+1 -1) 📝 `src/tools/ColorTool/ColorTool/ConsoleTargets/TerminalSchemeConsoleTarget.cs` (+1 -1) 📝 `src/tools/ColorTool/ColorTool/ConsoleTargets/VirtualTerminalConsoleTarget.cs` (+2 -3) 📝 `src/tools/ColorTool/ColorTool/Program.cs` (+25 -13) 📝 `src/tools/ColorTool/ColorTool/Resources.resx` (+32 -32) 📝 `src/tools/ColorTool/README.md` (+1 -0) </details> ### 📄 Description <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request - add suport for light backgrounds - make color tool use 90-97 and 100-107 sequences for fg/bg - fix loops stop condition <!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> ## References <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx <!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments additional improvements that I've seen while working on #12087 <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:00 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28824
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?