[PR #12097] [MERGED] Add an exportBuffer action #28847

Open
opened 2026-01-31 09:31:10 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12097
Author: @zadjii-msft
Created: 1/5/2022
Status: Merged
Merged: 1/12/2022
Merged by: @undefined

Base: mainHead: dev/migrie/f/9700-exportBufferAction


📝 Commits (4)

📊 Changes

11 files changed (+161 additions, -22 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+58 -0)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+21 -0)
📝 src/cascadia/TerminalApp/TabManagement.cpp (+36 -21)
📝 src/cascadia/TerminalApp/TerminalPage.h (+1 -1)
📝 src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp (+2 -0)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.cpp (+19 -0)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.h (+8 -0)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.idl (+6 -0)
📝 src/cascadia/TerminalSettingsModel/AllShortcutActions.h (+2 -0)
📝 src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw (+7 -0)
📝 src/cascadia/TerminalSettingsModel/defaults.json (+1 -0)

📄 Description

This adds an action for the context menu entry we added in #11062. That PR added support for exporting the buffer, exclusively through the tab item's context menu. This adds an action that can additionally be bound, which also can export the buffer to a file. This action accepts a path param. If empty/ommitted, then the Terminal will prompt for the file to export the buffer to.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12097 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/5/2022 **Status:** ✅ Merged **Merged:** 1/12/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/f/9700-exportBufferAction` --- ### 📝 Commits (4) - [`43c38aa`](https://github.com/microsoft/terminal/commit/43c38aa4ef94f54b13f823ca738acc2ac9e399c3) adds the basic plumbing all the way through - [`c307d5d`](https://github.com/microsoft/terminal/commit/c307d5da0da9be2dfa7b9b44e09458a4b6454f55) expanding env vars too is a good idea - [`c5a3885`](https://github.com/microsoft/terminal/commit/c5a38855fc3c395fb57fb9079551d7c9ec79b64d) schema - [`eabaa94`](https://github.com/microsoft/terminal/commit/eabaa94b7510defd92aefbf9a33edef71ff9ea71) pisker ### 📊 Changes **11 files changed** (+161 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+58 -0) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+21 -0) 📝 `src/cascadia/TerminalApp/TabManagement.cpp` (+36 -21) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+1 -1) 📝 `src/cascadia/TerminalSettingsModel/ActionAndArgs.cpp` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.cpp` (+19 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.h` (+8 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.idl` (+6 -0) 📝 `src/cascadia/TerminalSettingsModel/AllShortcutActions.h` (+2 -0) 📝 `src/cascadia/TerminalSettingsModel/Resources/en-US/Resources.resw` (+7 -0) 📝 `src/cascadia/TerminalSettingsModel/defaults.json` (+1 -0) </details> ### 📄 Description This adds an action for the context menu entry we added in #11062. That PR added support for exporting the buffer, exclusively through the tab item's context menu. This adds an action that can additionally be bound, which also can export the buffer to a file. This action accepts a `path` param. If empty/ommitted, then the Terminal will prompt for the file to export the buffer to. * Does a part of #9700 * Spec in #11090, but I doubt this is contentious * [x] This will satisfy #12052 * [x] I work here * [x] docs added: https://github.com/MicrosoftDocs/terminal/pull/479 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:10 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28847