[PR #12142] [CLOSED] Add a --elevate flag #28867

Open
opened 2026-01-31 09:31:17 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12142
Author: @zadjii-msft
Created: 1/11/2022
Status: Closed

Base: mainHead: dev/migrie/f/--elevate


📝 Commits (6)

  • 5caa902 Profile auto-elevation, version 3
  • 17f6f97 i didnt update the schema
  • f215222 Add a --elevate flag
  • 643ec46 Merge remote-tracking branch 'origin/main' into dev/migrie/f/--elevate
  • 63790b9 Merge remote-tracking branch 'origin/main' into dev/migrie/f/--elevate
  • 46c6403 This was my prototyped fix for the crash, but uuhhhhggggggg

📊 Changes

11 files changed (+103 additions, -2 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/CommandlineTest.cpp (+48 -0)
📝 src/cascadia/TerminalApp/AppCommandlineArgs.cpp (+11 -0)
📝 src/cascadia/TerminalApp/AppCommandlineArgs.h (+2 -0)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+5 -0)
📝 src/cascadia/TerminalApp/AppLogic.h (+1 -0)
📝 src/cascadia/TerminalApp/AppLogic.idl (+1 -0)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+4 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+25 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+1 -0)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.idl (+1 -1)
📝 src/cascadia/WindowsTerminal/AppHost.cpp (+4 -1)

📄 Description

To match the arg in #12137.

--elevate will manually elevate the profile.

--no-elevate will override a elevate: true in the profile with false.

So now you can wt --elevate cmd and it'll do what you think

  • I work here
  • Tests added
  • need to update docs

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12142 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/11/2022 **Status:** ❌ Closed **Base:** `main` ← **Head:** `dev/migrie/f/--elevate` --- ### 📝 Commits (6) - [`5caa902`](https://github.com/microsoft/terminal/commit/5caa90240c73d5f4faca38f3e353c5cb1713af54) Profile auto-elevation, version 3 - [`17f6f97`](https://github.com/microsoft/terminal/commit/17f6f97325672517175d31ef05f4fff5672bdc72) i didnt update the schema - [`f215222`](https://github.com/microsoft/terminal/commit/f215222bad584216ed23e38a7471a574ffdf6657) Add a `--elevate` flag - [`643ec46`](https://github.com/microsoft/terminal/commit/643ec46f88c9f8a411e40c7ceef928a90af7c1e1) Merge remote-tracking branch 'origin/main' into dev/migrie/f/--elevate - [`63790b9`](https://github.com/microsoft/terminal/commit/63790b9a5f6a2229ced10b6d6d2fe9b1c6a1e091) Merge remote-tracking branch 'origin/main' into dev/migrie/f/--elevate - [`46c6403`](https://github.com/microsoft/terminal/commit/46c6403ac1dc95db533a9e998a3feeb331e63abc) This was my prototyped fix for the crash, but uuhhhhggggggg ### 📊 Changes **11 files changed** (+103 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/CommandlineTest.cpp` (+48 -0) 📝 `src/cascadia/TerminalApp/AppCommandlineArgs.cpp` (+11 -0) 📝 `src/cascadia/TerminalApp/AppCommandlineArgs.h` (+2 -0) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+5 -0) 📝 `src/cascadia/TerminalApp/AppLogic.h` (+1 -0) 📝 `src/cascadia/TerminalApp/AppLogic.idl` (+1 -0) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+4 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+25 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+1 -0) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.idl` (+1 -1) 📝 `src/cascadia/WindowsTerminal/AppHost.cpp` (+4 -1) </details> ### 📄 Description To match the arg in #12137. `--elevate` will manually elevate the profile. `--no-elevate` will override a `elevate: true` in the profile with false. So now you can `wt --elevate cmd` and it'll do what you think * [x] I work here * [x] Tests added * [ ] need to update docs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:17 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28867