[PR #12144] [MERGED] Add a BreadcrumbBar to the SUI #28868

Open
opened 2026-01-31 09:31:18 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12144
Author: @PankajBhojwani
Created: 1/12/2022
Status: Merged
Merged: 1/28/2022
Merged by: @undefined

Base: mainHead: dev/pabhoj/SUI_breadcrumb


📝 Commits (10+)

📊 Changes

30 files changed (+1317 additions, -748 deletions)

View changed files

📝 .github/actions/spelling/allow/allow.txt (+2 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+1 -1)
📝 src/cascadia/TerminalSettingsEditor/CommonResources.xaml (+78 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+149 -25)
📝 src/cascadia/TerminalSettingsEditor/MainPage.h (+24 -2)
📝 src/cascadia/TerminalSettingsEditor/MainPage.idl (+16 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.xaml (+22 -2)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj (+45 -4)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters (+3 -1)
📝 src/cascadia/TerminalSettingsEditor/ProfileViewModel.cpp (+0 -1)
📝 src/cascadia/TerminalSettingsEditor/ProfileViewModel.h (+2 -4)
📝 src/cascadia/TerminalSettingsEditor/ProfileViewModel.idl (+3 -3)
📝 src/cascadia/TerminalSettingsEditor/Profiles.cpp (+0 -150)
📝 src/cascadia/TerminalSettingsEditor/Profiles.h (+0 -36)
📝 src/cascadia/TerminalSettingsEditor/Profiles.idl (+0 -8)
src/cascadia/TerminalSettingsEditor/Profiles.xaml (+0 -510)
src/cascadia/TerminalSettingsEditor/Profiles_Advanced.cpp (+31 -0)
src/cascadia/TerminalSettingsEditor/Profiles_Advanced.h (+31 -0)
src/cascadia/TerminalSettingsEditor/Profiles_Advanced.idl (+13 -0)
src/cascadia/TerminalSettingsEditor/Profiles_Advanced.xaml (+133 -0)

...and 10 more files

📄 Description

Summary of the Pull Request

Note: This PR targets #11720

Replaces our old pivot-style settings UI with a breadcrumb bar style, as per the windows 11 style guidelines. This required splitting Profiles.xaml into 3 separate files, Profiles_Base.xaml for general settings, Profiles_Appearance.xaml for appearance settings, Profiles_Advanced.xaml for advanced settings

The header in the navigation view is now a BreadcrumbBar, which can be used to navigate back to Profiles_Base after moving into the advanced or appearance page (see GIF below)

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

Validation Steps Performed

breadcrumb


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12144 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 1/12/2022 **Status:** ✅ Merged **Merged:** 1/28/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/SUI_breadcrumb` --- ### 📝 Commits (10+) - [`0b58355`](https://github.com/microsoft/terminal/commit/0b58355ef4b7b81b7b9d1a3ca99810dbcf9eaa6c) testing - [`ba4faec`](https://github.com/microsoft/terminal/commit/ba4faec04fa7761742c155bbd1345de0341e3d0f) got 2 styles that kinda work I guess - [`f3fd857`](https://github.com/microsoft/terminal/commit/f3fd85731dbdcc65f15c8bb254e0dbaaae4e643a) apparently this is the old expander - [`13bbcbf`](https://github.com/microsoft/terminal/commit/13bbcbf50f9476f22fd78a4e7f803e4de9d30f13) just use muxc:expander - [`81d0c5c`](https://github.com/microsoft/terminal/commit/81d0c5c2d7a28ecbaee9b2ce9f1337d64ce79305) remove remnants of previous implementation, format - [`61ae0a1`](https://github.com/microsoft/terminal/commit/61ae0a1a774feea8e116614e7c146aec794fcdf5) carlos comments - [`e6dffda`](https://github.com/microsoft/terminal/commit/e6dffdae886a3eba76e3cab330cdc7a6f8c2d6a7) merge main - [`de8a869`](https://github.com/microsoft/terminal/commit/de8a8696bf58f171541f251a74958e3e4ffbdb20) format - [`26652fe`](https://github.com/microsoft/terminal/commit/26652fe3823216a2b0c261848e480969e52d4475) left align actions - [`cefa906`](https://github.com/microsoft/terminal/commit/cefa9068d36cdb0dd4dfb65ff579ab4f07a7a7d7) add more margin for scroll bar ### 📊 Changes **30 files changed** (+1317 additions, -748 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/allow.txt` (+2 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+1 -1) 📝 `src/cascadia/TerminalSettingsEditor/CommonResources.xaml` (+78 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+149 -25) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.h` (+24 -2) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.idl` (+16 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.xaml` (+22 -2) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj` (+45 -4) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj.filters` (+3 -1) 📝 `src/cascadia/TerminalSettingsEditor/ProfileViewModel.cpp` (+0 -1) 📝 `src/cascadia/TerminalSettingsEditor/ProfileViewModel.h` (+2 -4) 📝 `src/cascadia/TerminalSettingsEditor/ProfileViewModel.idl` (+3 -3) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.cpp` (+0 -150) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.h` (+0 -36) 📝 `src/cascadia/TerminalSettingsEditor/Profiles.idl` (+0 -8) ➖ `src/cascadia/TerminalSettingsEditor/Profiles.xaml` (+0 -510) ➕ `src/cascadia/TerminalSettingsEditor/Profiles_Advanced.cpp` (+31 -0) ➕ `src/cascadia/TerminalSettingsEditor/Profiles_Advanced.h` (+31 -0) ➕ `src/cascadia/TerminalSettingsEditor/Profiles_Advanced.idl` (+13 -0) ➕ `src/cascadia/TerminalSettingsEditor/Profiles_Advanced.xaml` (+133 -0) _...and 10 more files_ </details> ### 📄 Description ## Summary of the Pull Request **Note: This PR targets #11720** Replaces our old pivot-style settings UI with a breadcrumb bar style, as per the windows 11 style guidelines. This required splitting `Profiles.xaml` into 3 separate files, `Profiles_Base.xaml` for general settings, `Profiles_Appearance.xaml` for appearance settings, `Profiles_Advanced.xaml` for advanced settings The header in the navigation view is now a [BreadcrumbBar](https://docs.microsoft.com/en-us/windows/apps/design/controls/breadcrumbbar), which can be used to navigate back to `Profiles_Base` after moving into the advanced or appearance page (see GIF below) <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed ![breadcrumb](https://user-images.githubusercontent.com/26824113/150410517-2232811e-4f5b-4732-9a0d-569cc94093b3.gif) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:18 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28868