[PR #12147] [MERGED] Make sure to copy connectionType for the azure shell #28874

Open
opened 2026-01-31 09:31:20 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12147
Author: @zadjii-msft
Created: 1/12/2022
Status: Merged
Merged: 1/12/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/12120-duplicate-azure


📝 Commits (1)

  • 12f7995 make sure to copy connectionType for the azure shell

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+7 -1)

📄 Description

This was a simple oversight. No user profile ever has connectionType set, because why would they. So even for the Azure Shell, which needed this, the check would fail and we'd forget to duplicate the connectionType to the new profile.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12147 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/12/2022 **Status:** ✅ Merged **Merged:** 1/12/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/12120-duplicate-azure` --- ### 📝 Commits (1) - [`12f7995`](https://github.com/microsoft/terminal/commit/12f79958ac29fb70c499daebdb784e151bbc3d1f) make sure to copy connectionType for the azure shell ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+7 -1) </details> ### 📄 Description This was a simple oversight. No user profile ever has `connectionType` set, because why would they. So even for the Azure Shell, which needed this, the check would fail and we'd forget to duplicate the connectionType to the new profile. * [x] I work here * [x] Closes #12120 * [x] Tested manually --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:20 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28874