[PR #12148] [MERGED] Remove unused Feature_ShowProfileDefaultsInSettings #28876

Open
opened 2026-01-31 09:31:20 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12148
Author: @zadjii-msft
Created: 1/12/2022
Status: Merged
Merged: 1/12/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/11454-remove-Feature_ShowProfileDefaultsInSettings


📝 Commits (2)

  • 91e4c53 the whole thing
  • e79ae5e remove it from where its actually defined, foo

📊 Changes

8 files changed (+18 additions, -63 deletions)

View changed files

📝 src/cascadia/LocalTests_SettingsModel/TerminalSettingsTests.cpp (+3 -11)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+0 -4)
📝 src/cascadia/TerminalSettingsEditor/MainPage.h (+0 -2)
📝 src/cascadia/TerminalSettingsEditor/MainPage.idl (+0 -2)
📝 src/cascadia/TerminalSettingsEditor/MainPage.xaml (+1 -2)
📝 src/cascadia/TerminalSettingsEditor/SettingContainer.cpp (+4 -17)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+10 -18)
📝 src/features.xml (+0 -7)

📄 Description

Title says it all. This is on by default, and we've committed to keeping it around. Having a velocity flag for it is redundant now.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12148 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/12/2022 **Status:** ✅ Merged **Merged:** 1/12/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/11454-remove-Feature_ShowProfileDefaultsInSettings` --- ### 📝 Commits (2) - [`91e4c53`](https://github.com/microsoft/terminal/commit/91e4c53a00c1b77c3b605dee67a5c68042f0c027) the whole thing - [`e79ae5e`](https://github.com/microsoft/terminal/commit/e79ae5e07a9899c89567430342bf99db6ec50aa7) remove it from where its actually defined, foo ### 📊 Changes **8 files changed** (+18 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_SettingsModel/TerminalSettingsTests.cpp` (+3 -11) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+0 -4) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.h` (+0 -2) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.idl` (+0 -2) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.xaml` (+1 -2) 📝 `src/cascadia/TerminalSettingsEditor/SettingContainer.cpp` (+4 -17) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+10 -18) 📝 `src/features.xml` (+0 -7) </details> ### 📄 Description Title says it all. This is on by default, and we've committed to keeping it around. Having a velocity flag for it is redundant now. * [x] Closes #11454 * [x] I work here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:20 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28876