starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12160] [MERGED] Disable being able to set the automatic adjustment of indistinguishable text #28877

New Issue
Open
opened 2026-01-31 09:31:21 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:31:21 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12160
Author: @PankajBhojwani
Created: 1/13/2022
Status: ✅ Merged
Merged: 1/18/2022
Merged by: @undefined

Base: main ← Head: dev/pabhoj/disable_adjust_text

📝 Commits (5)

📊 Changes

6 files changed (+19 additions, -2 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/Appearances.cpp (+5 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.h (+2 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.idl (+2 -0)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+2 -1)
📝 src/features.xml (+6 -0)
📝 src/renderer/base/RenderSettings.cpp (+2 -1)

📄 Description

Summary of the Pull Request

Disables the automatic adjustment of indistinguishable text (added in #11095) because of the concerns brought up in #11917. Also, the setting is hidden in the SUI for as long as this feature remains disabled.

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12160 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 1/13/2022 **Status:** ✅ Merged **Merged:** 1/18/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/disable_adjust_text` --- ### 📝 Commits (5) - [`1e0989a`](https://github.com/microsoft/terminal/commit/1e0989a49d3ccc4eaf9bce7d5a12185f3a09012f) default to false, set SUI item behind feature flag - [`17b8bd7`](https://github.com/microsoft/terminal/commit/17b8bd701aff24dd13b5b2f9794fda76873d2f17) more feature enabled checks - [`fdc7679`](https://github.com/microsoft/terminal/commit/fdc7679c8cdd4812410c8456292b54c59c08810a) conflict - [`20286c0`](https://github.com/microsoft/terminal/commit/20286c0423c024a674911989afa776d6fecd69a2) update - [`3b949ea`](https://github.com/microsoft/terminal/commit/3b949ea46043fee41126b2f4f01e437ef234b197) swap order ### 📊 Changes **6 files changed** (+19 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/Appearances.cpp` (+5 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.h` (+2 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.idl` (+2 -0) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+2 -1) 📝 `src/features.xml` (+6 -0) 📝 `src/renderer/base/RenderSettings.cpp` (+2 -1) </details> ### 📄 Description ## Summary of the Pull Request Disables the automatic adjustment of indistinguishable text (added in #11095) because of the concerns brought up in #11917. Also, the setting is hidden in the SUI for as long as this feature remains disabled. ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:21 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28877
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?