[PR #12162] [CLOSED] Remove delta E code from release 1.12 branch #28878

Open
opened 2026-01-31 09:31:21 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12162
Author: @PankajBhojwani
Created: 1/14/2022
Status: Closed

Base: release-1.12Head: dev/pabhoj/delete_delta_e_1.12


📝 Commits (10+)

  • 26f4b0e Merged PR 6269653: Slim down conhost's dependency on shcore
  • dfda410 Merged PR 6274354: [Git2Git] Fix unbound read of cooked read buffer
  • 01b5195 Merged PR 6277720: [Git2Git] Merged PR 6275065: Trace console attach/detatch
  • 184919f Merged PR 6285331: [Git2Git] Merged PR 6278637: Expose attached client process context to cooked read trace
  • 431d51d Merged PR 6286783: Release unneeded memory more eagerly from conhost
  • d26353b Merged PR 6303540: Prepare command history before COOKED_READ in tests
  • dc86552 Migrate OSS up to f9a844dbd
  • 8b8ad75 Update version to 1.13 on main (#11550)
  • 5cd9663 Fixed VsDevCmd command line quoting (#11554)
  • 670ae2b Link 1.12 blog and milestones on roadmap (#11562)

📊 Changes

858 files changed (+21851 additions, -15665 deletions)

View changed files

📝 .github/ISSUE_TEMPLATE/Bug_Report.yml (+13 -6)
📝 .github/actions/spelling/allow/allow.txt (+13 -5)
📝 .github/actions/spelling/allow/apis.txt (+19 -0)
📝 .github/actions/spelling/allow/math.txt (+0 -7)
📝 .github/actions/spelling/allow/names.txt (+1 -0)
📝 .github/actions/spelling/excludes.txt (+2 -0)
📝 .github/actions/spelling/expect/expect.txt (+38 -24)
📝 .github/actions/spelling/expect/web.txt (+9 -2)
📝 .github/actions/spelling/patterns/patterns.txt (+4 -1)
📝 .vsconfig (+1 -1)
📝 CONTRIBUTING.md (+17 -3)
📝 NOTICE.md (+0 -37)
📝 NuGet.Config (+2 -0)
📝 OpenConsole.sln (+90 -51)
📝 README.md (+6 -4)
📝 Scratch.sln (+1 -1)
📝 build/Helix/EnsureMachineState.ps1 (+1 -1)
📝 build/Helix/HelixTestHelpers.cs (+1 -1)
build/config/PolicheckExclusions.xml (+11 -0)
📝 build/packages.config (+1 -0)

...and 80 more files

📄 Description

Summary of the Pull Request

Note: this pr targets release 1.12

Delete the delta E code from release 1.12 instead of putting it behind a feature flag because we are never going to go back to turn it on

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12162 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 1/14/2022 **Status:** ❌ Closed **Base:** `release-1.12` ← **Head:** `dev/pabhoj/delete_delta_e_1.12` --- ### 📝 Commits (10+) - [`26f4b0e`](https://github.com/microsoft/terminal/commit/26f4b0eacbe46e47d89960064edb161f18471d21) Merged PR 6269653: Slim down conhost's dependency on shcore - [`dfda410`](https://github.com/microsoft/terminal/commit/dfda41074d8a3735c42a5ee17e1b4997571e00f9) Merged PR 6274354: [Git2Git] Fix unbound read of cooked read buffer - [`01b5195`](https://github.com/microsoft/terminal/commit/01b519527548167e96ac5983e1881829429bba6a) Merged PR 6277720: [Git2Git] Merged PR 6275065: Trace console attach/detatch - [`184919f`](https://github.com/microsoft/terminal/commit/184919fb24186b161b40be8e004bf2c0d99ff1ee) Merged PR 6285331: [Git2Git] Merged PR 6278637: Expose attached client process context to cooked read trace - [`431d51d`](https://github.com/microsoft/terminal/commit/431d51de4c7219aa49e12f5468add009a517949b) Merged PR 6286783: Release unneeded memory more eagerly from conhost - [`d26353b`](https://github.com/microsoft/terminal/commit/d26353bb32587a38d595ee75fa0b5a737dc3123d) Merged PR 6303540: Prepare command history before COOKED_READ in tests - [`dc86552`](https://github.com/microsoft/terminal/commit/dc865529b58d5c4afe3cda65b82d1b9493207709) Migrate OSS up to f9a844dbd - [`8b8ad75`](https://github.com/microsoft/terminal/commit/8b8ad7502400b45889e6f7f8e3e8b73064d32468) Update version to 1.13 on main (#11550) - [`5cd9663`](https://github.com/microsoft/terminal/commit/5cd966326913298f9d5570717a94972728f63065) Fixed VsDevCmd command line quoting (#11554) - [`670ae2b`](https://github.com/microsoft/terminal/commit/670ae2bd1c78fd2cc5b8e88f426eacab71fe1bfb) Link 1.12 blog and milestones on roadmap (#11562) ### 📊 Changes **858 files changed** (+21851 additions, -15665 deletions) <details> <summary>View changed files</summary> 📝 `.github/ISSUE_TEMPLATE/Bug_Report.yml` (+13 -6) 📝 `.github/actions/spelling/allow/allow.txt` (+13 -5) 📝 `.github/actions/spelling/allow/apis.txt` (+19 -0) 📝 `.github/actions/spelling/allow/math.txt` (+0 -7) 📝 `.github/actions/spelling/allow/names.txt` (+1 -0) 📝 `.github/actions/spelling/excludes.txt` (+2 -0) 📝 `.github/actions/spelling/expect/expect.txt` (+38 -24) 📝 `.github/actions/spelling/expect/web.txt` (+9 -2) 📝 `.github/actions/spelling/patterns/patterns.txt` (+4 -1) 📝 `.vsconfig` (+1 -1) 📝 `CONTRIBUTING.md` (+17 -3) 📝 `NOTICE.md` (+0 -37) 📝 `NuGet.Config` (+2 -0) 📝 `OpenConsole.sln` (+90 -51) 📝 `README.md` (+6 -4) 📝 `Scratch.sln` (+1 -1) 📝 `build/Helix/EnsureMachineState.ps1` (+1 -1) 📝 `build/Helix/HelixTestHelpers.cs` (+1 -1) ➕ `build/config/PolicheckExclusions.xml` (+11 -0) 📝 `build/packages.config` (+1 -0) _...and 80 more files_ </details> ### 📄 Description ## Summary of the Pull Request **Note: this pr targets release 1.12** Delete the delta E code from release 1.12 instead of putting it behind a feature flag because we are never going to go back to turn it on ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:21 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28878