starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12163] [MERGED] Revert delta E change for release 1.12 #28886

New Issue
Open
opened 2026-01-31 09:31:25 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:31:25 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12163
Author: @PankajBhojwani
Created: 1/14/2022
Status: ✅ Merged
Merged: 1/14/2022
Merged by: @miniksa

Base: release-1.12 ← Head: dev/pabhoj/delete_delta_e

📝 Commits (1)

  • 83b9a4c Revert "Implement the Delta E algorithm to improve color perception (#11095)"

📊 Changes

23 files changed (+9 additions, -453 deletions)

View changed files

📝 .github/actions/spelling/allow/math.txt (+0 -7)
📝 .github/actions/spelling/expect/web.txt (+0 -2)
📝 NOTICE.md (+0 -37)
📝 doc/cascadia/profiles.schema.json (+0 -8)
➖ src/cascadia/TerminalCore/ColorFix.cpp (+0 -228)
➖ src/cascadia/TerminalCore/ColorFix.hpp (+0 -49)
📝 src/cascadia/TerminalCore/ICoreAppearance.idl (+0 -1)
📝 src/cascadia/TerminalCore/Terminal.cpp (+1 -7)
📝 src/cascadia/TerminalCore/Terminal.hpp (+0 -4)
📝 src/cascadia/TerminalCore/terminalcore-common.vcxitems (+0 -2)
📝 src/cascadia/TerminalCore/terminalrenderdata.cpp (+7 -76)
📝 src/cascadia/TerminalSettingsEditor/Appearances.h (+1 -2)
📝 src/cascadia/TerminalSettingsEditor/Appearances.idl (+0 -1)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+0 -8)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+0 -8)
📝 src/cascadia/TerminalSettingsModel/AppearanceConfig.cpp (+0 -4)
📝 src/cascadia/TerminalSettingsModel/AppearanceConfig.h (+0 -2)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+0 -1)
📝 src/cascadia/TerminalSettingsModel/IAppearanceConfig.idl (+0 -1)
📝 src/cascadia/TerminalSettingsModel/TerminalSettings.cpp (+0 -1)

...and 3 more files

📄 Description

Summary of the Pull Request

Remove the delta E code from release 1.12 instead of putting it behind a feature flag since we are never going to go back to enable it anyway.

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12163 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 1/14/2022 **Status:** ✅ Merged **Merged:** 1/14/2022 **Merged by:** [@miniksa](https://github.com/miniksa) **Base:** `release-1.12` ← **Head:** `dev/pabhoj/delete_delta_e` --- ### 📝 Commits (1) - [`83b9a4c`](https://github.com/microsoft/terminal/commit/83b9a4c3ceda2904d833c27df5c57c31ce093918) Revert "Implement the Delta E algorithm to improve color perception (#11095)" ### 📊 Changes **23 files changed** (+9 additions, -453 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/math.txt` (+0 -7) 📝 `.github/actions/spelling/expect/web.txt` (+0 -2) 📝 `NOTICE.md` (+0 -37) 📝 `doc/cascadia/profiles.schema.json` (+0 -8) ➖ `src/cascadia/TerminalCore/ColorFix.cpp` (+0 -228) ➖ `src/cascadia/TerminalCore/ColorFix.hpp` (+0 -49) 📝 `src/cascadia/TerminalCore/ICoreAppearance.idl` (+0 -1) 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+1 -7) 📝 `src/cascadia/TerminalCore/Terminal.hpp` (+0 -4) 📝 `src/cascadia/TerminalCore/terminalcore-common.vcxitems` (+0 -2) 📝 `src/cascadia/TerminalCore/terminalrenderdata.cpp` (+7 -76) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.h` (+1 -2) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.idl` (+0 -1) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+0 -8) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+0 -8) 📝 `src/cascadia/TerminalSettingsModel/AppearanceConfig.cpp` (+0 -4) 📝 `src/cascadia/TerminalSettingsModel/AppearanceConfig.h` (+0 -2) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+0 -1) 📝 `src/cascadia/TerminalSettingsModel/IAppearanceConfig.idl` (+0 -1) 📝 `src/cascadia/TerminalSettingsModel/TerminalSettings.cpp` (+0 -1) _...and 3 more files_ </details> ### 📄 Description ## Summary of the Pull Request Remove the delta E code from release 1.12 instead of putting it behind a feature flag since we are never going to go back to enable it anyway. ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:25 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28886
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?