starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12209] Add support for ctrl+click on the dropdown to launch elevated #28899

New Issue
Open
opened 2026-01-31 09:31:31 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:31:31 +00:00
Owner
Copy Link

Original Pull Request: https://github.com/microsoft/terminal/pull/12209

State: closed
Merged: Yes

image

Just like the shift+click and the alt click shortcuts, now Ctrl+Click will launch a new window with that profile, elevated.

I also found that the GenerateName wasn't updated for the elevate arg, so added that. I considered adding the following to the defaults, but decided against it. It added 10 more entries to the command palette that were only separated by the elevate: true param, so that didn't feel valuable. Those are posted below for posterity.

Considered new keybindings:

        { "command": { "action": "newTab", "index": 0, "elevate": true }, "keys": "ctrl+shift+alt+1" },
        { "command": { "action": "newTab", "index": 1, "elevate": true }, "keys": "ctrl+shift+alt+2" },
        { "command": { "action": "newTab", "index": 2, "elevate": true }, "keys": "ctrl+shift+alt+3" },
        { "command": { "action": "newTab", "index": 3, "elevate": true }, "keys": "ctrl+shift+alt+4" },
        { "command": { "action": "newTab", "index": 4, "elevate": true }, "keys": "ctrl+shift+alt+5" },
        { "command": { "action": "newTab", "index": 5, "elevate": true }, "keys": "ctrl+shift+alt+6" },
        { "command": { "action": "newTab", "index": 6, "elevate": true }, "keys": "ctrl+shift+alt+7" },
        { "command": { "action": "newTab", "index": 7, "elevate": true }, "keys": "ctrl+shift+alt+8" },
        { "command": { "action": "newTab", "index": 8, "elevate": true }, "keys": "ctrl+shift+alt+9" },

Includes a semi-related dead code removal for the elevated param for _OpenNewWindow, which didn't end up being used, and wouldn't work as intended anyways.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/12209 **State:** closed **Merged:** Yes --- ![image](https://user-images.githubusercontent.com/18356694/150421834-de68140b-a935-47d7-95ca-ab91a6421f1b.png) Just like the shift+click and the alt click shortcuts, now Ctrl+Click will launch a new window with that profile, elevated. I also found that the GenerateName wasn't updated for the elevate arg, so added that. I considered adding the following to the defaults, but decided against it. It added 10 more entries to the command palette that were only separated by the `elevate: true` param, so that didn't feel valuable. Those are posted below for posterity. * [x] closes https://github.com/microsoft/terminal/projects/5#card-50759221 * [x] Tested manually * [ ] Docs.... maybe need updating? Considered new keybindings: ```jsonc { "command": { "action": "newTab", "index": 0, "elevate": true }, "keys": "ctrl+shift+alt+1" }, { "command": { "action": "newTab", "index": 1, "elevate": true }, "keys": "ctrl+shift+alt+2" }, { "command": { "action": "newTab", "index": 2, "elevate": true }, "keys": "ctrl+shift+alt+3" }, { "command": { "action": "newTab", "index": 3, "elevate": true }, "keys": "ctrl+shift+alt+4" }, { "command": { "action": "newTab", "index": 4, "elevate": true }, "keys": "ctrl+shift+alt+5" }, { "command": { "action": "newTab", "index": 5, "elevate": true }, "keys": "ctrl+shift+alt+6" }, { "command": { "action": "newTab", "index": 6, "elevate": true }, "keys": "ctrl+shift+alt+7" }, { "command": { "action": "newTab", "index": 7, "elevate": true }, "keys": "ctrl+shift+alt+8" }, { "command": { "action": "newTab", "index": 8, "elevate": true }, "keys": "ctrl+shift+alt+9" }, ``` Includes a semi-related dead code removal for the `elevated` param for `_OpenNewWindow`, which didn't end up being used, and wouldn't work as intended anyways.
claunia added the pull-request label 2026-01-31 09:31:31 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28899
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?