[PR #12226] [MERGED] AtlasEngine: Redraw immediately on opacity changes #28904

Open
opened 2026-01-31 09:31:33 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12226
Author: @lhecker
Created: 1/24/2022
Status: ✅ Merged
Merged: 1/25/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/atlas-engine-opacity-refresh


📝 Commits (1)

  • e92bb2a Redraw AtlasEngine immediately on opacity changes

📊 Changes

5 files changed (+21 additions, -21 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.cpp (+1 -0)
📝 src/renderer/base/renderer.cpp (+11 -11)
📝 src/renderer/base/renderer.hpp (+1 -1)
📝 src/renderer/base/thread.cpp (+4 -4)
📝 src/renderer/base/thread.hpp (+4 -5)

📄 Description

Since AtlasEngine prefers drawing without alpha for performance reasons,
calls to EnableTransparentBackground require a draw cycle.
This PR makes Renderer::_NotifyPaintFrame public and calls it.

Related to #9999.

PR Checklist

  • I work here
  • Tests added/passed

Validation Steps Performed

  • Open Windows Terminal command palette
  • Choose "Set background opacity..."
  • Cycling through the items without selecting one
    changes background opacity immediately ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12226 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 1/24/2022 **Status:** ✅ Merged **Merged:** 1/25/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/atlas-engine-opacity-refresh` --- ### 📝 Commits (1) - [`e92bb2a`](https://github.com/microsoft/terminal/commit/e92bb2a4a3c769afe50b5e09428152f0ce0960ef) Redraw AtlasEngine immediately on opacity changes ### 📊 Changes **5 files changed** (+21 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+1 -0) 📝 `src/renderer/base/renderer.cpp` (+11 -11) 📝 `src/renderer/base/renderer.hpp` (+1 -1) 📝 `src/renderer/base/thread.cpp` (+4 -4) 📝 `src/renderer/base/thread.hpp` (+4 -5) </details> ### 📄 Description Since `AtlasEngine` prefers drawing without alpha for performance reasons, calls to `EnableTransparentBackground` require a draw cycle. This PR makes `Renderer::_NotifyPaintFrame` public and calls it. Related to #9999. ## PR Checklist * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * Open Windows Terminal command palette * Choose "Set background opacity..." * Cycling through the items without selecting one changes background opacity immediately ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:33 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28904