starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12210] [MERGED] Send an updated cursor position at the end of writing a run #28908

New Issue
Open
opened 2026-01-31 09:31:34 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:31:34 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12210
Author: @zadjii-msft
Created: 1/20/2022
Status: ✅ Merged
Merged: 1/25/2022
Merged by: @undefined

Base: main ← Head: dev/migrie/b/11170-cursorpositionchanged-events

📝 Commits (8)

  • 16477b7 This fixes #11170, but a test would be nice
  • e9eceec a test too, because I'm a good person
  • fd54b72 Merge remote-tracking branch 'origin/main' into dev/migrie/b/11170-cursorpositionchanged-events
  • af05ad8 Uh oh someone broke main on an FI
  • 67441eb This is potentially cleaner, but I have another idea
  • d0fb6dd Even cleaner solution
  • b99167e Merge remote-tracking branch 'origin/main' into dev/migrie/b/11170-cursorpositionchanged-events
  • b7c8c0c Merge remote-tracking branch 'origin/main' into dev/migrie/b/11170-cursorpositionchanged-events

📊 Changes

2 files changed (+56 additions, -7 deletions)

View changed files

📝 src/cascadia/TerminalCore/Terminal.cpp (+14 -7)
📝 src/cascadia/UnitTests_TerminalCore/TerminalBufferTests.cpp (+42 -0)

📄 Description

I can find the commit where this regressed tomorrow if needed. In #10685 we stopped emitting these notifications while we were deferring cursor drawing. We however forgot to send the notification at the end of the defer.

This likely has a small perf impact. We however do need these cursor position events for IMEs to be able to track the cursor position (and low key for #10821)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12210 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/20/2022 **Status:** ✅ Merged **Merged:** 1/25/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/11170-cursorpositionchanged-events` --- ### 📝 Commits (8) - [`16477b7`](https://github.com/microsoft/terminal/commit/16477b734a9696aa47b2cfcb432efc62a8dafc2b) This fixes #11170, but a test would be nice - [`e9eceec`](https://github.com/microsoft/terminal/commit/e9eceec37deb4c1a74e9cc22eaabe9a617a228cd) a test too, because I'm a good person - [`fd54b72`](https://github.com/microsoft/terminal/commit/fd54b72a5aac9dd9f61921bb187156bdf88286f7) Merge remote-tracking branch 'origin/main' into dev/migrie/b/11170-cursorpositionchanged-events - [`af05ad8`](https://github.com/microsoft/terminal/commit/af05ad84c985290fd80c3bbefc5317eda0a5e6d2) Uh oh someone broke main on an FI - [`67441eb`](https://github.com/microsoft/terminal/commit/67441eb88fb39429a1a1f0280c72335d7ed2702e) This is potentially cleaner, but I have another idea - [`d0fb6dd`](https://github.com/microsoft/terminal/commit/d0fb6dd94cfbe8e67fb80ef47a0b1e9447f26c73) Even cleaner solution - [`b99167e`](https://github.com/microsoft/terminal/commit/b99167e5cfe9c302df1152e53f24b41ac27863fd) Merge remote-tracking branch 'origin/main' into dev/migrie/b/11170-cursorpositionchanged-events - [`b7c8c0c`](https://github.com/microsoft/terminal/commit/b7c8c0cbbe928dcf3a874079a699f8c437258d32) Merge remote-tracking branch 'origin/main' into dev/migrie/b/11170-cursorpositionchanged-events ### 📊 Changes **2 files changed** (+56 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalCore/Terminal.cpp` (+14 -7) 📝 `src/cascadia/UnitTests_TerminalCore/TerminalBufferTests.cpp` (+42 -0) </details> ### 📄 Description I can find the commit where this regressed tomorrow if needed. In #10685 we stopped emitting these notifications while we were deferring cursor drawing. We however forgot to send the notification at the end of the defer. This likely has a small perf impact. We however do need these cursor position events for IMEs to be able to track the cursor position (and low key for #10821) * [x] regressed in #10685 * [x] Closes #11170 * [x] I work here * [x] Tests added --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:34 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28908
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?