[PR #12229] [MERGED] Fix opacity restore for command palette previews #28915

Open
opened 2026-01-31 09:31:37 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12229
Author: @lhecker
Created: 1/24/2022
Status: ✅ Merged
Merged: 1/24/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/fix-opacity-restore


📝 Commits (1)

  • a48c3cf Fix opacity restore for command palette previews

📊 Changes

8 files changed (+33 additions, -26 deletions)

View changed files

📝 src/cascadia/TerminalApp/ActionPreviewHandlers.cpp (+26 -18)
📝 src/cascadia/TerminalApp/AppActionHandlers.cpp (+1 -1)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+1 -2)
📝 src/cascadia/TerminalControl/ControlCore.h (+1 -1)
📝 src/cascadia/TerminalControl/ControlCore.idl (+1 -1)
📝 src/cascadia/TerminalControl/TermControl.cpp (+1 -1)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -1)
📝 src/cascadia/TerminalControl/TermControl.idl (+1 -1)

📄 Description

This commit correctly restores the previous opacity when the command palette
preview is cancelled. It includes an additional change in order to make the
AdjustOpacity setter consistent and symmetric with the Opacity getter.

PR Checklist

Validation Steps Performed

  • Open Windows Terminal command palette
  • Choose "Set background opacity..."
  • Cycle through the items without selecting one
  • Press Escape
  • Previous opacity is restored ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12229 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 1/24/2022 **Status:** ✅ Merged **Merged:** 1/24/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/fix-opacity-restore` --- ### 📝 Commits (1) - [`a48c3cf`](https://github.com/microsoft/terminal/commit/a48c3cf7d52c657f6a3f1bfcc8195abaaf3b8441) Fix opacity restore for command palette previews ### 📊 Changes **8 files changed** (+33 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/ActionPreviewHandlers.cpp` (+26 -18) 📝 `src/cascadia/TerminalApp/AppActionHandlers.cpp` (+1 -1) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+1 -2) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+1 -1) 📝 `src/cascadia/TerminalControl/ControlCore.idl` (+1 -1) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+1 -1) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -1) 📝 `src/cascadia/TerminalControl/TermControl.idl` (+1 -1) </details> ### 📄 Description This commit correctly restores the previous opacity when the command palette preview is cancelled. It includes an additional change in order to make the `AdjustOpacity` setter consistent and symmetric with the `Opacity` getter. ## PR Checklist * [x] Closes #12228 * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * Open Windows Terminal command palette * Choose "Set background opacity..." * Cycle through the items without selecting one * Press Escape * Previous opacity is restored ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:37 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28915