[PR #12284] [MERGED] Use the macros for duplicating as well #28953

Open
opened 2026-01-31 09:31:51 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12284
Author: @zadjii-msft
Created: 1/28/2022
Status: ✅ Merged
Merged: 1/31/2022
Merged by: @undefined

Base: main ← Head: dev/migrie/b/12265-duplicate-with-macro


📝 Commits (2)

📊 Changes

2 files changed (+35 additions, -29 deletions)

View changed files

📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+22 -29)
📝 src/cascadia/TerminalSettingsModel/MTSMSettings.h (+13 -0)

📄 Description

Introduced in #11416

We weren't using these macros for duplicating as well, so I forgot to duplicate a couple settings. This PR switches duplicating over to using the macros as well, which shou;d reduce future bugs.

Also adds notes to which properties are intentionally omitted from these macros.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12284 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/28/2022 **Status:** ✅ Merged **Merged:** 1/31/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/12265-duplicate-with-macro` --- ### 📝 Commits (2) - [`d1ca9b7`](https://github.com/microsoft/terminal/commit/d1ca9b7a244280e29a66faa228da160abf2af68f) use the macros for duplicating as well - [`d500504`](https://github.com/microsoft/terminal/commit/d500504060de5d5c3498395c06c56559a7bf8bca) spel ### 📊 Changes **2 files changed** (+35 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+22 -29) 📝 `src/cascadia/TerminalSettingsModel/MTSMSettings.h` (+13 -0) </details> ### 📄 Description Introduced in #11416 We weren't using these macros for duplicating as well, so I forgot to duplicate a couple settings. This PR switches duplicating over to using the macros as well, which shou;d reduce future bugs. Also adds notes to which properties are intentionally omitted from these macros. * [x] closes #12265 * [x] Verified manually that #12120 still works as expected --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:51 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28953