[PR #12301] [MERGED] Make the SearchBox announce if it found results or not #28961

Open
opened 2026-01-31 09:31:53 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12301
Author: @zadjii-msft
Created: 1/31/2022
Status: Merged
Merged: 1/31/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/11973-find-announce


📝 Commits (3)

📊 Changes

9 files changed (+62 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalControl/ControlCore.cpp (+7 -1)
📝 src/cascadia/TerminalControl/ControlCore.h (+1 -0)
📝 src/cascadia/TerminalControl/ControlCore.idl (+1 -0)
📝 src/cascadia/TerminalControl/EventArgs.cpp (+1 -0)
📝 src/cascadia/TerminalControl/EventArgs.h (+12 -0)
📝 src/cascadia/TerminalControl/EventArgs.idl (+6 -0)
📝 src/cascadia/TerminalControl/Resources/en-US/Resources.resw (+8 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+25 -0)
📝 src/cascadia/TerminalControl/TermControl.h (+1 -0)

📄 Description

Basically, this is the same as #12266, but for the SearchBoxControl. Trickily, the ControlCore is the one that knows if there were search results, but the TermControl has to be the one to announce it.

  • Will take care of #11973 once a11y team confirms
  • Tested manually with Narrator
  • Resolves a part of #6319, which I'm repurposing just to displaying the number of results in general.
  • See also Ubuntu terminal crashes (#3920)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12301 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 1/31/2022 **Status:** ✅ Merged **Merged:** 1/31/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/11973-find-announce` --- ### 📝 Commits (3) - [`4e67123`](https://github.com/microsoft/terminal/commit/4e67123cf2af15662d49f5956b801809e7163ebe) The whole thing - [`d03eb67`](https://github.com/microsoft/terminal/commit/d03eb670c2c69bc7ca374501aaa40edb5030eb24) typo - [`15a973b`](https://github.com/microsoft/terminal/commit/15a973bfc3b2fbddd7d0b4e0fc85a538e1e588e1) comments to resw too ### 📊 Changes **9 files changed** (+62 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+7 -1) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+1 -0) 📝 `src/cascadia/TerminalControl/ControlCore.idl` (+1 -0) 📝 `src/cascadia/TerminalControl/EventArgs.cpp` (+1 -0) 📝 `src/cascadia/TerminalControl/EventArgs.h` (+12 -0) 📝 `src/cascadia/TerminalControl/EventArgs.idl` (+6 -0) 📝 `src/cascadia/TerminalControl/Resources/en-US/Resources.resw` (+8 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+25 -0) 📝 `src/cascadia/TerminalControl/TermControl.h` (+1 -0) </details> ### 📄 Description Basically, this is the same as #12266, but for the `SearchBoxControl`. Trickily, the ControlCore is the one that knows if there were search results, but the TermControl has to be the one to announce it. * [x] Will take care of #11973 once a11y team confirms * [x] Tested manually with Narrator * [x] Resolves a part of #6319, which I'm repurposing just to displaying the number of results in general. * See also #3920 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:53 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28961