[PR #12287] [MERGED] Fix a number of small issues with the SUI #28963

Open
opened 2026-01-31 09:31:54 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12287
Author: @PankajBhojwani
Created: 1/28/2022
Status: Merged
Merged: 1/31/2022
Merged by: @undefined

Base: mainHead: dev/pabhoj/sui_fixes


📝 Commits (3)

📊 Changes

5 files changed (+12 additions, -28 deletions)

View changed files

📝 src/cascadia/TerminalSettingsEditor/CommonResources.xaml (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj (+0 -4)
src/cascadia/TerminalSettingsEditor/Profiles.cpp (+0 -23)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Base.xaml (+9 -0)
📝 src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml (+2 -1)

📄 Description

Summary of the Pull Request

Fix various things from the recent SUI changes

  • The Appearance/Advanced toggle buttons now have a max width
  • We don't need Profiles.cpp anymore
  • The Elevate setting is now back in the SUI
  • There is no longer an alignment difference between non-expander settings and expander settings
  • Expander settings no longer require hitting Tab twice to get to them

PR Checklist

  • Closes #xxx
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Documentation updated. If checked, please file a pull request on our docs repo and link it here: #xxx
  • Schema updated.
  • I work here

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12287 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 1/28/2022 **Status:** ✅ Merged **Merged:** 1/31/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/sui_fixes` --- ### 📝 Commits (3) - [`9a224ed`](https://github.com/microsoft/terminal/commit/9a224ed1150a37d3faa48de139e7d0bb2feb8a62) various fixes - [`9e98412`](https://github.com/microsoft/terminal/commit/9e98412b6886ee6cf4c8ce40f6b833b287ebbdb0) tabstop - [`aa3de13`](https://github.com/microsoft/terminal/commit/aa3de134fc36c309168ff2f1fcb04f663e0a3fce) format ### 📊 Changes **5 files changed** (+12 additions, -28 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalSettingsEditor/CommonResources.xaml` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/Microsoft.Terminal.Settings.Editor.vcxproj` (+0 -4) ➖ `src/cascadia/TerminalSettingsEditor/Profiles.cpp` (+0 -23) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Base.xaml` (+9 -0) 📝 `src/cascadia/TerminalSettingsEditor/SettingContainerStyle.xaml` (+2 -1) </details> ### 📄 Description ## Summary of the Pull Request Fix various things from the recent SUI changes - The Appearance/Advanced toggle buttons now have a max width - We don't need `Profiles.cpp` anymore - The `Elevate` setting is now back in the SUI - There is no longer an alignment difference between non-expander settings and expander settings - Expander settings no longer require hitting `Tab` twice to get to them <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [ ] Closes #xxx * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:31:54 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28963