[PR #12296] Fixed #11875. Enclosed configuration Frame in ScrollViewer to keep scroll position in settings pages #28969

Open
opened 2026-01-31 09:31:55 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/12296

State: closed
Merged: No


Summary of the Pull Request

This PR attempts to solve issue #11875. I was able to make the scroll position persistent by enclosing the Frame in a ScrollViewer. Currently, the existing animation allows you to see that a reload happened, but the scroll position is never changed.

PR Checklist

Validation Steps Performed

I manually tested this behavior.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/12296 **State:** closed **Merged:** No --- <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This PR attempts to solve issue #11875. I was able to make the scroll position persistent by enclosing the `Frame` in a `ScrollViewer`. Currently, the existing animation allows you to see that a reload happened, but the scroll position is never changed. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist * [x] Closes #11875 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #11875. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed I manually tested this behavior.
claunia added the pull-request label 2026-01-31 09:31:56 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28969