starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12326] [MERGED] Fix more SUI and Rejuvenated UI issues #28981

New Issue
Open
opened 2026-01-31 09:32:03 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:32:03 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12326
Author: @PankajBhojwani
Created: 2/2/2022
Status: ✅ Merged
Merged: 2/2/2022
Merged by: @undefined

Base: main ← Head: dev/pabhoj/sui_centralize

📝 Commits (7)

📊 Changes

9 files changed (+179 additions, -154 deletions)

View changed files

📝 src/cascadia/TerminalApp/App.xaml (+8 -8)
📝 src/cascadia/TerminalSettingsEditor/Actions.xaml (+24 -23)
📝 src/cascadia/TerminalSettingsEditor/AddProfile.xaml (+39 -33)
📝 src/cascadia/TerminalSettingsEditor/Appearances.xaml (+4 -4)
📝 src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml (+2 -1)
📝 src/cascadia/TerminalSettingsEditor/CommonResources.xaml (+10 -2)
📝 src/cascadia/TerminalSettingsEditor/MainPage.xaml (+7 -2)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Appearance.xaml (+12 -10)
📝 src/cascadia/TerminalSettingsEditor/Profiles_Base.xaml (+73 -71)

📄 Description

  • The add new profile page now uses a dropdown rather than radio buttons
  • Subheaders, breadcrumb bar, buttons etc are now all centralized when the window is maximized (so they all align with the expanders now)
  • We no longer override the titlebar colors and instead use the xaml defaults (these still aren't great but at least we will get the fix automatically when it happens upstream)
  • Breadcrumb bar no longer has a negative margin, so there's no weird overlap that happens when the window becomes small
  • The number boxes for launch size and font size now use the Inline placement mode rather than compact, allowing modification to the number with fewer clicks
  • Textboxes now have a greater max width so they can occupy more space in the expander if needed

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12326 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 2/2/2022 **Status:** ✅ Merged **Merged:** 2/2/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/sui_centralize` --- ### 📝 Commits (7) - [`3adcbc4`](https://github.com/microsoft/terminal/commit/3adcbc45c5b66639e21a15c25d3e3c6e261d34b3) fixes - [`9962cba`](https://github.com/microsoft/terminal/commit/9962cbacca1159d3de565eb4b46450806ccf81b2) text box width - [`1d0d1a5`](https://github.com/microsoft/terminal/commit/1d0d1a51c1522586ad273452afe36ec0e7e9061c) max width is now a static resource, fix duplicate profile combo box - [`0d6f5bf`](https://github.com/microsoft/terminal/commit/0d6f5bf6951a0ecb32bbce712748bd03b74c7ceb) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/sui_centralize - [`6533926`](https://github.com/microsoft/terminal/commit/6533926ff13005482180c7fffc07f044ffe9f364) use standard control max width, change unfocused border brush - [`69716f0`](https://github.com/microsoft/terminal/commit/69716f0dc42916d14b7452d5cfef37f7c8cc8a48) conflict - [`d5569ff`](https://github.com/microsoft/terminal/commit/d5569ff8002b6ec99bd50fe9cab546a3972ee2d1) format ### 📊 Changes **9 files changed** (+179 additions, -154 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/App.xaml` (+8 -8) 📝 `src/cascadia/TerminalSettingsEditor/Actions.xaml` (+24 -23) 📝 `src/cascadia/TerminalSettingsEditor/AddProfile.xaml` (+39 -33) 📝 `src/cascadia/TerminalSettingsEditor/Appearances.xaml` (+4 -4) 📝 `src/cascadia/TerminalSettingsEditor/ColorSchemes.xaml` (+2 -1) 📝 `src/cascadia/TerminalSettingsEditor/CommonResources.xaml` (+10 -2) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.xaml` (+7 -2) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Appearance.xaml` (+12 -10) 📝 `src/cascadia/TerminalSettingsEditor/Profiles_Base.xaml` (+73 -71) </details> ### 📄 Description - The add new profile page now uses a dropdown rather than radio buttons - Subheaders, breadcrumb bar, buttons etc are now all centralized when the window is maximized (so they all align with the expanders now) - We no longer override the titlebar colors and instead use the xaml defaults (these still aren't great but at least we will get the fix automatically when it happens upstream) - Breadcrumb bar no longer has a negative margin, so there's no weird overlap that happens when the window becomes small - The number boxes for launch size and font size now use the `Inline` placement mode rather than compact, allowing modification to the number with fewer clicks - Textboxes now have a greater max width so they can occupy more space in the expander if needed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:32:03 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28981
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?