[PR #12337] [MERGED] appx: Use a different resource for the Properties DisplayName #28991

Open
opened 2026-01-31 09:32:08 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12337
Author: @DHowett
Created: 2/3/2022
Status: Merged
Merged: 2/3/2022
Merged by: @DHowett

Base: mainHead: dev/duhowett/wait-can-i-fix-the-displayname


📝 Commits (1)

  • 9ad0adc Use a different resource for the Properties DisplayName (yeah)

📊 Changes

4 files changed (+13 additions, -3 deletions)

View changed files

📝 src/cascadia/CascadiaPackage/Package-Dev.appxmanifest (+1 -1)
📝 src/cascadia/CascadiaPackage/Package-Pre.appxmanifest (+1 -1)
📝 src/cascadia/CascadiaPackage/Package.appxmanifest (+1 -1)
📝 src/cascadia/TerminalApp/Resources/en-US/ContextMenu.resw (+10 -0)

📄 Description

We have to do this so that the store sees us as one thing ("Windows
Terminal") and the Start menu sees us as another ("Terminal").

The store will reject our package if the value we use for "DisplayName"
here doesn't match the store's "reserved names".

This value is not used by the start menu.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12337 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 2/3/2022 **Status:** ✅ Merged **Merged:** 2/3/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/duhowett/wait-can-i-fix-the-displayname` --- ### 📝 Commits (1) - [`9ad0adc`](https://github.com/microsoft/terminal/commit/9ad0adcfd62cdcba9f3f0a2d81e669f914cf45a6) Use a different resource for the Properties DisplayName (yeah) ### 📊 Changes **4 files changed** (+13 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/CascadiaPackage/Package-Dev.appxmanifest` (+1 -1) 📝 `src/cascadia/CascadiaPackage/Package-Pre.appxmanifest` (+1 -1) 📝 `src/cascadia/CascadiaPackage/Package.appxmanifest` (+1 -1) 📝 `src/cascadia/TerminalApp/Resources/en-US/ContextMenu.resw` (+10 -0) </details> ### 📄 Description We have to do this so that the store sees us as one thing ("Windows Terminal") and the Start menu sees us as another ("Terminal"). The store will reject our package if the value we use for "DisplayName" here doesn't match the store's "reserved names". This value is *not used* by the start menu. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:32:08 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28991