starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12348] [MERGED] Fix profile matching for paths containing unquoted whitespace #28994

New Issue
Open
opened 2026-01-31 09:32:08 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:32:08 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12348
Author: @lhecker
Created: 2/3/2022
Status: ✅ Merged
Merged: 2/8/2022
Merged by: @undefined

Base: main ← Head: dev/lhecker/12345-profile-matching-fixup

📝 Commits (1)

  • 5781b81 Fix profile matching for paths containing unquoted whitespace

📊 Changes

4 files changed (+99 additions, -34 deletions)

View changed files

📝 .github/actions/spelling/allow/apis.txt (+9 -7)
📝 src/cascadia/LocalTests_SettingsModel/TerminalSettingsTests.cpp (+54 -0)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp (+35 -26)
📝 src/cascadia/TerminalSettingsModel/CascadiaSettings.h (+1 -1)

📄 Description

The previous code had two bugs for:

  • paths with more than 1 whitespace
    The code joins the argv array by replacing null-word terminators with
    whitespace. Unfortunately it always referred to the separator between
    argv[0] and argv[1] for this instead of continuing to join
    those between 1 and 2, etc.
  • paths sharing a common prefix with another directory
    SearchPathW returns paths that aren't necessarily paths to files.
    A call to GetFileAttributesW was added, ensuring we only resolve file paths.

PR Checklist

Validation Steps Performed

  • Paths with more than 1 whitespace resolve correctly ✅
  • Paths with neighboring directories sharing a common prefix resolve correctly ✅
  • Tests added ✅

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12348 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 2/3/2022 **Status:** ✅ Merged **Merged:** 2/8/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/12345-profile-matching-fixup` --- ### 📝 Commits (1) - [`5781b81`](https://github.com/microsoft/terminal/commit/5781b81374ed4f360541a967d2fea5ded1d1f8a8) Fix profile matching for paths containing unquoted whitespace ### 📊 Changes **4 files changed** (+99 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/apis.txt` (+9 -7) 📝 `src/cascadia/LocalTests_SettingsModel/TerminalSettingsTests.cpp` (+54 -0) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp` (+35 -26) 📝 `src/cascadia/TerminalSettingsModel/CascadiaSettings.h` (+1 -1) </details> ### 📄 Description The previous code had two bugs for: * paths with more than 1 whitespace The code joins the argv array by replacing null-word terminators with whitespace. Unfortunately it always referred to the separator between `argv[0]` and `argv[1]` for this instead of continuing to join those between 1 and 2, etc. * paths sharing a common prefix with another directory `SearchPathW` returns paths that aren't necessarily paths to files. A call to `GetFileAttributesW` was added, ensuring we only resolve file paths. ## PR Checklist * [x] Closes #12345 * [x] I work here * [ ] Tests added/passed ## Validation Steps Performed * Paths with more than 1 whitespace resolve correctly ✅ * Paths with neighboring directories sharing a common prefix resolve correctly ✅ * Tests added ✅ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:32:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#28994
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?