starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12375] [MERGED] Hardcode the language list for the package manifest and settings dropdown #29001

New Issue
Open
opened 2026-01-31 09:32:11 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:32:11 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12375
Author: @miniksa
Created: 2/4/2022
Status: ✅ Merged
Merged: 2/5/2022
Merged by: @undefined

Base: main ← Head: dev/miniksa/locales

📝 Commits (10+)

  • 597b119 hardcode the language list
  • df3eafb spelling for pseudolocale variations to exceptions list.
  • c911ac8 Dustin's right, we only build dev as en-US.
  • 22b9f22 Testing this since the context menu didn't change.... NNNNN
  • 7170ad7 Add ALL the languages because reasons.
  • faada38 spell check
  • c69e74c Code the languages into the app
  • b1f047d Drop the Languages one per Leonard. Change to let the array initialize itself with c-strings
  • 7b8243b you're really on my case, spellcheck
  • 4a09933 what's an emplace between friends

📊 Changes

5 files changed (+214 additions, -35 deletions)

View changed files

📝 .github/actions/spelling/expect/expect.txt (+7 -0)
📝 src/cascadia/CascadiaPackage/Package-Dev.appxmanifest (+1 -1)
📝 src/cascadia/CascadiaPackage/Package-Pre.appxmanifest (+89 -1)
📝 src/cascadia/CascadiaPackage/Package.appxmanifest (+89 -1)
📝 src/cascadia/TerminalSettingsEditor/GlobalAppearance.cpp (+28 -32)

📄 Description

The x-generate statement seems to have fallen apart somewhere and is no longer generating the valid list of languages for display. This hardcodes the list into the manifest to restore it, which is a valid option per the documentation.

We also hardcode the limited subset of languages into the Settings application because the main application supports fewer languages than we have been translated into for the shell extensions for Windows Explorer and Start Menu integration.

PR Checklist

Validation Steps Performed

  • Clean built locally with msbuild.exe openconsole.sln /p:Configuration=Release /p:Platform=x64 /p:WindowsTerminalBranding=Release /t:Terminal\CascadiaPackage /m /bl:log4.binlog and checked that the appxmanifest.xml that popped out the other side contained the same languages that it used to contain.
  • Built in the release pipeline
  • Installed release and preview branded packages. Changed my machine language to Polish (pl-PL) which is not one of the fully localized languages, but is one of the limited ones. Checked the start menu and right-click menus and saw Polish text for Terminal and Terminal Preview. Checked the Settings page in our app and saw only the limited 14 language list for the application itself.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12375 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 2/4/2022 **Status:** ✅ Merged **Merged:** 2/5/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/miniksa/locales` --- ### 📝 Commits (10+) - [`597b119`](https://github.com/microsoft/terminal/commit/597b119154c9a9884f8590f81dc41773e1d8d77c) hardcode the language list - [`df3eafb`](https://github.com/microsoft/terminal/commit/df3eafbc44aac4967a4d7868ce6d8ff2763836f6) spelling for pseudolocale variations to exceptions list. - [`c911ac8`](https://github.com/microsoft/terminal/commit/c911ac8a795c6ffca5341751ddcfbf5488c7868d) Dustin's right, we only build dev as en-US. - [`22b9f22`](https://github.com/microsoft/terminal/commit/22b9f22b7e3dcb41b401f2d49d4c87521d3246b2) Testing this since the context menu didn't change.... NNNNN - [`7170ad7`](https://github.com/microsoft/terminal/commit/7170ad74bedf7979662203578258299981e551a4) Add ALL the languages because reasons. - [`faada38`](https://github.com/microsoft/terminal/commit/faada38f939e47f78becde32666d5e3ab2b9c082) spell check - [`c69e74c`](https://github.com/microsoft/terminal/commit/c69e74cdebecc6d338cec7041851db48d4fd11d6) Code the languages into the app - [`b1f047d`](https://github.com/microsoft/terminal/commit/b1f047dbf9e881988c9abfdb420dd745df0c8161) Drop the Languages one per Leonard. Change to let the array initialize itself with c-strings - [`7b8243b`](https://github.com/microsoft/terminal/commit/7b8243b280449fa84f3441c1c1258b50fc5a31b3) you're really on my case, spellcheck - [`4a09933`](https://github.com/microsoft/terminal/commit/4a0993359db0003a49036f52cfedf3526e74561c) what's an emplace between friends ### 📊 Changes **5 files changed** (+214 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/expect/expect.txt` (+7 -0) 📝 `src/cascadia/CascadiaPackage/Package-Dev.appxmanifest` (+1 -1) 📝 `src/cascadia/CascadiaPackage/Package-Pre.appxmanifest` (+89 -1) 📝 `src/cascadia/CascadiaPackage/Package.appxmanifest` (+89 -1) 📝 `src/cascadia/TerminalSettingsEditor/GlobalAppearance.cpp` (+28 -32) </details> ### 📄 Description The `x-generate` statement seems to have fallen apart somewhere and is no longer generating the valid list of languages for display. This hardcodes the list into the manifest to restore it, which is a valid option per the documentation. We also hardcode the limited subset of languages into the Settings application because the main application supports fewer languages than we have been translated into for the shell extensions for Windows Explorer and Start Menu integration. ## PR Checklist * [x] Closes #12351 * [x] I work here. * [x] Manual tests below ## Validation Steps Performed - [x] Clean built locally with `msbuild.exe openconsole.sln /p:Configuration=Release /p:Platform=x64 /p:WindowsTerminalBranding=Release /t:Terminal\CascadiaPackage /m /bl:log4.binlog` and checked that the `appxmanifest.xml` that popped out the other side contained the same languages that it used to contain. - [x] Built in the release pipeline - [x] Installed release and preview branded packages. Changed my machine language to Polish (pl-PL) which is not one of the fully localized languages, but is one of the limited ones. Checked the start menu and right-click menus and saw Polish text for Terminal and Terminal Preview. Checked the Settings page in our app and saw only the limited 14 language list for the application itself. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:32:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29001
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?