[PR #12389] Eliminate the DispatchCommon class #29017

Open
opened 2026-01-31 09:32:16 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/12389

State: closed
Merged: Yes


Summary of the Pull Request

Other than the s_ResizeWindow function, the DispatchCommon class was
just a couple of static functions indirectly calling the ConGetSet
interface. So by moving the s_ResizeWindow implementation into the
ConhostInternalGetSet class, we could easily replace all usage of
DispatchCommon with direct calls to ConGetSet.

PR Checklist

Validation Steps Performed

I've manually confirmed the resizing operations still work as expected.
The other functions are harder to test, but were trivial replacements.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/12389 **State:** closed **Merged:** Yes --- ## Summary of the Pull Request Other than the `s_ResizeWindow` function, the `DispatchCommon` class was just a couple of static functions indirectly calling the `ConGetSet` interface. So by moving the `s_ResizeWindow` implementation into the `ConhostInternalGetSet` class, we could easily replace all usage of `DispatchCommon` with direct calls to `ConGetSet`. ## PR Checklist * [x] Closes #12253 * [x] CLA signed. * [ ] Tests added/passed * [ ] Documentation updated. * [ ] Schema updated. * [x] I've discussed this with core contributors already. Issue number where discussion took place: #12253 ## Validation Steps Performed I've manually confirmed the resizing operations still work as expected. The other functions are harder to test, but were trivial replacements.
claunia added the pull-request label 2026-01-31 09:32:16 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29017