[PR #12430] [MERGED] Fix a potential crash when setting up the jumplist #29021

Open
opened 2026-01-31 09:32:18 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12430
Author: @zadjii-msft
Created: 2/8/2022
Status: Merged
Merged: 2/8/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/12360-weird


📝 Commits (1)

  • 65ba41e Fix a potential crash when setting up the jumplist

📊 Changes

1 file changed (+13 additions, -0 deletions)

View changed files

📝 src/cascadia/TerminalApp/Jumplist.cpp (+13 -0)

📄 Description

I have no idea how this is even possible to hit. If this is able to be null, then we failed to load the settings in such a catastrophic way that nothing should work. However, OP's Terminal seemed to have already loaded the settings. By all accounts, doesn't make sense.

Regardless, the code here would crash if this ever is null, so we may as well catch it.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12430 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 2/8/2022 **Status:** ✅ Merged **Merged:** 2/8/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/12360-weird` --- ### 📝 Commits (1) - [`65ba41e`](https://github.com/microsoft/terminal/commit/65ba41e38b22e6782e7b461aa74c23b955cd4ba9) Fix a potential crash when setting up the jumplist ### 📊 Changes **1 file changed** (+13 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/Jumplist.cpp` (+13 -0) </details> ### 📄 Description I have no idea how this is even possible to hit. If this is able to be null, then we failed to load the settings in such a catastrophic way that nothing should work. However, OP's Terminal seemed to have already loaded the settings. By all accounts, doesn't make sense. Regardless, the code here would crash if this ever is null, so we may as well catch it. * [x] Closes #12360 * [ ] No way to verify this since it isn't even reproable on OPs machine, but it does have a lot of hits for that failure bucket (!!!) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:32:18 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29021