[PR #12429] [MERGED] Update the cmdpal narrator message to include the number of results. #29022

Open
opened 2026-01-31 09:32:19 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12429
Author: @zadjii-msft
Created: 2/8/2022
Status: Merged
Merged: 2/11/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/7907-multiple-messages


📝 Commits (4)

📊 Changes

2 files changed (+6 additions, -3 deletions)

View changed files

📝 src/cascadia/TerminalApp/CommandPalette.cpp (+3 -1)
📝 src/cascadia/TerminalApp/Resources/en-US/Resources.resw (+3 -2)

📄 Description

Updates this narrator announcement message to include the number of results it found. There are two versions:

  • one for a singular result
  • one for multiple results.

which should help with loc.

We're trying to get this in with the loc hotfix, so 👀 please

  • will take care of the last bit of #7907

verified with narrator locally.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12429 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 2/8/2022 **Status:** ✅ Merged **Merged:** 2/11/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/7907-multiple-messages` --- ### 📝 Commits (4) - [`c41a7bd`](https://github.com/microsoft/terminal/commit/c41a7bde2a51ffd699e240e2814b70d835337b48) this works - [`9bd8891`](https://github.com/microsoft/terminal/commit/9bd889106a54ede9a030b3288b6c9432c4175d0e) cleanup - [`54007c1`](https://github.com/microsoft/terminal/commit/54007c172bef3ec589dfe82e671cfae97d00526b) spel is hard - [`4c0e6cc`](https://github.com/microsoft/terminal/commit/4c0e6cc8659da0d14a0a28a66dd3c84b054e7998) This seems like a good enough work around for now ### 📊 Changes **2 files changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/CommandPalette.cpp` (+3 -1) 📝 `src/cascadia/TerminalApp/Resources/en-US/Resources.resw` (+3 -2) </details> ### 📄 Description Updates this narrator announcement message to include the number of results it found. There are two versions: * one for a singular result * one for multiple results. which should help with loc. We're trying to get this in with the loc hotfix, so 👀 please * [x] will take care of the last bit of #7907 verified with narrator locally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:32:19 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29022