[PR #12442] [MERGED] Fix defterm + elevate by default #29041

Open
opened 2026-01-31 09:32:25 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12442
Author: @zadjii-msft
Created: 2/8/2022
Status: Merged
Merged: 2/9/2022
Merged by: @DHowett

Base: mainHead: dev/migrie/b/12370-defterm-default-elevate


📝 Commits (2)

📊 Changes

2 files changed (+7 additions, -4 deletions)

View changed files

📝 src/cascadia/TerminalApp/TerminalPage.cpp (+6 -3)
📝 src/cascadia/TerminalSettingsModel/ActionArgs.idl (+1 -1)

📄 Description

We absolutely cannot allow a defterm connection to
auto-elevate. Defterm doesn't work for elevated senarios in the
first place. If we try accepting the connection, the spawning an
elevated version of the Terminal with that profile... that's a
recipe for disaster. We won't ever open up a tab in this window.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12442 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 2/8/2022 **Status:** ✅ Merged **Merged:** 2/9/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/migrie/b/12370-defterm-default-elevate` --- ### 📝 Commits (2) - [`065e689`](https://github.com/microsoft/terminal/commit/065e6891124622cec7ab38e9f0eb45b3764a929b) Fix defterm + elevate by default - [`45390d3`](https://github.com/microsoft/terminal/commit/45390d35b5578ca719e5987872e76d171a1e76f1) spel ### 📊 Changes **2 files changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+6 -3) 📝 `src/cascadia/TerminalSettingsModel/ActionArgs.idl` (+1 -1) </details> ### 📄 Description We absolutely cannot allow a defterm connection to auto-elevate. Defterm doesn't work for elevated senarios in the first place. If we try accepting the connection, the spawning an elevated version of the Terminal with that profile... that's a recipe for disaster. We won't ever open up a tab in this window. * [x] Closes #12370 * [x] Tested manually, since there's not a great way to add defterm tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:32:25 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29041