[PR #12450] [MERGED] Source index the public symbols too #29052

Open
opened 2026-01-31 09:32:29 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12450
Author: @miniksa
Created: 2/9/2022
Status: ✅ Merged
Merged: 2/11/2022
Merged by: @undefined

Base: main ← Head: dev/miniksa/public_sourcelink


📝 Commits (5)

  • 4eef1fb try source indexing the public symbols
  • 48e5507 temporarily nerf actual public publishing while I'm testing
  • 8ab36b0 having debuggers is nice.
  • fc9d481 Dustin and I have different ideas on what the short hand for temporary is...
  • 2aba01f Revert "temporarily nerf actual public publishing while I'm testing"

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 build/pipelines/release.yml (+8 -0)

📄 Description

Now that we've figured out how to publish the public symbols to the official Microsoft download server... we may as well embed the source code linking information inside of them given that it's right here on GitHub. This attempts to run our existing source linking scripts against the public copy of the symbols.

PR Checklist

Validation Steps Performed


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12450 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 2/9/2022 **Status:** ✅ Merged **Merged:** 2/11/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/miniksa/public_sourcelink` --- ### 📝 Commits (5) - [`4eef1fb`](https://github.com/microsoft/terminal/commit/4eef1fbd8bcd2facf4ced2a7f963d4541dc7c20c) try source indexing the public symbols - [`48e5507`](https://github.com/microsoft/terminal/commit/48e55070895384d117139c14c7e39bf1f7e742ad) temporarily nerf actual public publishing while I'm testing - [`8ab36b0`](https://github.com/microsoft/terminal/commit/8ab36b011eec2b15a846a2ae4acab6383624b7b2) having debuggers is nice. - [`fc9d481`](https://github.com/microsoft/terminal/commit/fc9d4814b6c35643dac24a908d995bb9736c5a59) Dustin and I have different ideas on what the short hand for temporary is... - [`2aba01f`](https://github.com/microsoft/terminal/commit/2aba01f7e2e962d1c88c9ac4a639365bdd20661c) Revert "temporarily nerf actual public publishing while I'm testing" ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `build/pipelines/release.yml` (+8 -0) </details> ### 📄 Description Now that we've figured out how to publish the public symbols to the official Microsoft download server... we may as well embed the source code linking information inside of them given that it's right here on GitHub. This attempts to run our existing source linking scripts against the public copy of the symbols. ## PR Checklist * [x] Closes #12443 * [x] I work here * [x] Tested manually ## Validation Steps Performed * [x] Build with it: https://dev.azure.com/microsoft/Dart/_build/results?buildId=44930661&view=logs&j=8f802011-b567-5b81-5fa6-bce316c020ce * [x] Point the debugger at them and see if it can find the sources * [x] Maybe also look at them in a hex editor or whatnot and validate I can see the source paths pointing at GitHub --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:32:29 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29052