[PR #12460] Manually set the colors of the TabViewBackground #29058

Open
opened 2026-01-31 09:32:30 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/12460

State: closed
Merged: Yes


This has been a saga.

Basically, any resources in App.xaml aren't going to be able to reference other theme-aware resources. We can't change the theme of the app at runtime, only elements within the app. So we can't use ApplicationPageBackgroundThemeBrush in app.xaml, because it will ALWAYS be evaluated as the OS theme version of that brush.

**Original Pull Request:** https://github.com/microsoft/terminal/pull/12460 **State:** closed **Merged:** Yes --- This has been a saga. Basically, any resources in `App.xaml` aren't going to be able to reference other theme-aware resources. We can't change the theme of the app at runtime, only elements within the app. So we can't use `ApplicationPageBackgroundThemeBrush` in app.xaml, because it will ALWAYS be evaluated as the OS theme version of that brush. * regressed in #12326 * See also #10864 * #3917 CANNOT be fixed in the same way. We're lucky here that the TabView uses a `{ThemeResource TabViewBackground}` in markup to set the bg. We're not similarly lucky with the Pane one. * [x] closes #12356 * [x] Tested manually. You can confirm, my eyes are bleeding from the OS-wide light mode
claunia added the pull-request label 2026-01-31 09:32:30 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29058