[PR #12505] [MERGED] Replace "acrylic" with "acrylic material" in i18n strings #29071

Open
opened 2026-01-31 09:32:36 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12505
Author: @lhecker
Created: 2/16/2022
Status: Merged
Merged: 2/18/2022
Merged by: @undefined

Base: mainHead: dev/lhecker/acrylic-translation


📝 Commits (4)

  • ac55a18 Replace "acrylic" with "acrylic material" in i18n strings
  • e3c3de3 Address feedback
  • 8b65a83 Address feedback
  • 5f76de6 Address feedback

📊 Changes

2 files changed (+9 additions, -21 deletions)

View changed files

📝 doc/cascadia/profiles.schema.json (+2 -2)
📝 src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw (+7 -19)

📄 Description

"Acrylic material" is the official name as used on Microsoft Docs
and should ensure it gets properly translated in all languages.

PR Checklist

Detailed Description of the Pull Request / Additional comments

We originally intended to replace the strings with "acrylic transparency",
but "acrylic material" is actually the official term on Microsoft Docs.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12505 **Author:** [@lhecker](https://github.com/lhecker) **Created:** 2/16/2022 **Status:** ✅ Merged **Merged:** 2/18/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/lhecker/acrylic-translation` --- ### 📝 Commits (4) - [`ac55a18`](https://github.com/microsoft/terminal/commit/ac55a18065ae8d38bc355d705a16a4ceb99a0fd0) Replace "acrylic" with "acrylic material" in i18n strings - [`e3c3de3`](https://github.com/microsoft/terminal/commit/e3c3de3be6b036f62bbcb46897a226150e7e8628) Address feedback - [`8b65a83`](https://github.com/microsoft/terminal/commit/8b65a83b2f157740bca4a0655dc474c5836a0601) Address feedback - [`5f76de6`](https://github.com/microsoft/terminal/commit/5f76de68602bf5146b202ee76af10733dc2da366) Address feedback ### 📊 Changes **2 files changed** (+9 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `doc/cascadia/profiles.schema.json` (+2 -2) 📝 `src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw` (+7 -19) </details> ### 📄 Description "Acrylic material" is the official name as used on Microsoft Docs and should ensure it gets properly translated in all languages. ## PR Checklist * [x] Closes #9846 * [x] Closes MSFT:36776499 * [x] I work here ## Detailed Description of the Pull Request / Additional comments We originally intended to replace the strings with "acrylic transparency", but "acrylic material" is actually the official term on Microsoft Docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:32:36 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29071