[PR #12517] [MERGED] No longer load content dialogs when there is already one being shown #29082

Open
opened 2026-01-31 09:32:39 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12517
Author: @PankajBhojwani
Created: 2/17/2022
Status: ✅ Merged
Merged: 2/18/2022
Merged by: @undefined

Base: main ← Head: dev/pabhoj/close_tabs_dialog


📝 Commits (5)

📊 Changes

7 files changed (+57 additions, -34 deletions)

View changed files

📝 src/cascadia/TerminalApp/AppLogic.cpp (+8 -0)
📝 src/cascadia/TerminalApp/AppLogic.h (+1 -0)
📝 src/cascadia/TerminalApp/AppLogic.idl (+2 -5)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+33 -29)
📝 src/cascadia/TerminalApp/TerminalPage.h (+3 -0)
📝 src/cascadia/TerminalApp/TerminalPage.idl (+2 -0)
📝 src/cascadia/TerminalApp/TerminalPage.xaml (+8 -0)

📄 Description

Summary of the Pull Request

Somehow, the controls v2 update caused an issue where if you as much as load a content dialog when there's already one open, we get holes in the terminal window (#12447)

This commit introduces logic to TerminalPage to check whether there is a content dialog open before we try to load another one.

PR Checklist

Validation Steps Performed

Can no longer repro #12447


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12517 **Author:** [@PankajBhojwani](https://github.com/PankajBhojwani) **Created:** 2/17/2022 **Status:** ✅ Merged **Merged:** 2/18/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/pabhoj/close_tabs_dialog` --- ### 📝 Commits (5) - [`163e0d5`](https://github.com/microsoft/terminal/commit/163e0d59607c64e555eaeb54c2833e5df8f8ecb5) don't load dialog if one is already open - [`4ea5aba`](https://github.com/microsoft/terminal/commit/4ea5aba1c3f0a7774e7de52546f37b9e4774f0c4) Merge branch 'main' of https://github.com/microsoft/terminal into dev/pabhoj/close_tabs_dialog - [`0cc7af4`](https://github.com/microsoft/terminal/commit/0cc7af4b01955ac119167a4db9fd65e51deed358) show dialog helper - [`c3ed323`](https://github.com/microsoft/terminal/commit/c3ed3234007afe92970d708bde54a99479bafb25) about dialog helper - [`70f8d64`](https://github.com/microsoft/terminal/commit/70f8d64b1150e58eae91957f153c1f3506bbaf62) remove idialogpresenter methods ### 📊 Changes **7 files changed** (+57 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+8 -0) 📝 `src/cascadia/TerminalApp/AppLogic.h` (+1 -0) 📝 `src/cascadia/TerminalApp/AppLogic.idl` (+2 -5) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+33 -29) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+3 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.idl` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.xaml` (+8 -0) </details> ### 📄 Description ## Summary of the Pull Request Somehow, the controls v2 update caused an issue where if you as much as _load_ a content dialog when there's already one open, we get holes in the terminal window (#12447) This commit introduces logic to `TerminalPage` to check whether there is a content dialog open before we try to load another one. ## PR Checklist * [x] Closes #12447 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed Can no longer repro #12447 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:32:39 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29082