starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 08:24:54 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12515] [MERGED] Propagate show/hide window calls against the ConPTY pseudo window to the Terminal #29084

New Issue
Open
opened 2026-01-31 09:32:40 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:32:40 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12515
Author: @miniksa
Created: 2/17/2022
Status: ✅ Merged
Merged: 4/27/2022
Merged by: @undefined

Base: main ← Head: dev/miniksa/msgs

📝 Commits (10+)

📊 Changes

52 files changed (+940 additions, -8 deletions)

View changed files

📝 .github/actions/spelling/allow/apis.txt (+1 -0)
📝 .github/actions/spelling/expect/expect.txt (+11 -0)
➕ doc/specs/#12570 - Show Hide operations on GetConsoleWindow via PTY.md (+370 -0)
📝 src/cascadia/TerminalApp/AppLogic.cpp (+16 -0)
📝 src/cascadia/TerminalApp/AppLogic.h (+2 -0)
📝 src/cascadia/TerminalApp/AppLogic.idl (+2 -0)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+44 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+5 -0)
📝 src/cascadia/TerminalApp/TerminalPage.idl (+1 -0)
📝 src/cascadia/TerminalConnection/ConptyConnection.cpp (+15 -0)
📝 src/cascadia/TerminalConnection/ConptyConnection.h (+4 -0)
📝 src/cascadia/TerminalConnection/ConptyConnection.idl (+4 -0)
📝 src/cascadia/TerminalControl/ControlCore.cpp (+28 -0)
📝 src/cascadia/TerminalControl/ControlCore.h (+4 -0)
📝 src/cascadia/TerminalControl/ControlCore.idl (+2 -0)
📝 src/cascadia/TerminalControl/EventArgs.cpp (+1 -0)
📝 src/cascadia/TerminalControl/EventArgs.h (+12 -0)
📝 src/cascadia/TerminalControl/EventArgs.idl (+5 -0)
📝 src/cascadia/TerminalControl/TermControl.cpp (+13 -0)
📝 src/cascadia/TerminalControl/TermControl.h (+3 -0)

...and 32 more files

📄 Description

Propagate show/hide window calls against the ConPTY pseudo window to the Terminal

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • See the spec. It's pretty much everything I went through deciding on this.

Validation Steps Performed

  • Manual validation against scratch application calling all of the ::ShowWindow commands against the pseudo console "fake window" and observing the real terminal window state

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12515 **Author:** [@miniksa](https://github.com/miniksa) **Created:** 2/17/2022 **Status:** ✅ Merged **Merged:** 4/27/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/miniksa/msgs` --- ### 📝 Commits (10+) - [`24fe610`](https://github.com/microsoft/terminal/commit/24fe6103e06d58a7cb89d4d28790f5c26f764230) Sub out default window proc with our own pseudo window proc. - [`861683c`](https://github.com/microsoft/terminal/commit/861683c6d3acad01a7c33e0998a8b3366a9f01ea) sneak out the messages to the output thread. - [`8d24f23`](https://github.com/microsoft/terminal/commit/8d24f236d2cd342de711b8f678bfb54210f58aa8) Piping... piping.... doo doo doo doo... doo-doo. - [`48e37a5`](https://github.com/microsoft/terminal/commit/48e37a518b0c999ce67e4d9a96898cd828812bf6) More piping... - [`9ab0c75`](https://github.com/microsoft/terminal/commit/9ab0c75fb72abdb229b1ae6575c52ae7b4977e69) Core stuff? - [`3d1ad43`](https://github.com/microsoft/terminal/commit/3d1ad436aa67ea2afaf77d237b3948c865a07cdf) I swear I just get more lost. - [`9c67d94`](https://github.com/microsoft/terminal/commit/9c67d94016f25ffe115127e17c6d87c31dfde346) write island trigger - [`687cdda`](https://github.com/microsoft/terminal/commit/687cdda756b8283c0ac59469e84585cc695261d9) more piping - [`4f06371`](https://github.com/microsoft/terminal/commit/4f0637127805d668084fdd0de125c722bf1c18ff) make it blend - [`da8775b`](https://github.com/microsoft/terminal/commit/da8775b7667fb37903d54a5098cf648a107dcb73) format! ### 📊 Changes **52 files changed** (+940 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/apis.txt` (+1 -0) 📝 `.github/actions/spelling/expect/expect.txt` (+11 -0) ➕ `doc/specs/#12570 - Show Hide operations on GetConsoleWindow via PTY.md` (+370 -0) 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+16 -0) 📝 `src/cascadia/TerminalApp/AppLogic.h` (+2 -0) 📝 `src/cascadia/TerminalApp/AppLogic.idl` (+2 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+44 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+5 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.idl` (+1 -0) 📝 `src/cascadia/TerminalConnection/ConptyConnection.cpp` (+15 -0) 📝 `src/cascadia/TerminalConnection/ConptyConnection.h` (+4 -0) 📝 `src/cascadia/TerminalConnection/ConptyConnection.idl` (+4 -0) 📝 `src/cascadia/TerminalControl/ControlCore.cpp` (+28 -0) 📝 `src/cascadia/TerminalControl/ControlCore.h` (+4 -0) 📝 `src/cascadia/TerminalControl/ControlCore.idl` (+2 -0) 📝 `src/cascadia/TerminalControl/EventArgs.cpp` (+1 -0) 📝 `src/cascadia/TerminalControl/EventArgs.h` (+12 -0) 📝 `src/cascadia/TerminalControl/EventArgs.idl` (+5 -0) 📝 `src/cascadia/TerminalControl/TermControl.cpp` (+13 -0) 📝 `src/cascadia/TerminalControl/TermControl.h` (+3 -0) _...and 32 more files_ </details> ### 📄 Description Propagate show/hide window calls against the ConPTY pseudo window to the Terminal ## PR Checklist * [x] Closes #12570 * [x] I work here * [x] Manual Tests passed * [x] Spec Link: →[Doc Link](https://github.com/microsoft/terminal/blob/dev/miniksa/msgs/doc/specs/%2312570%20-%20Show%20Hide%20operations%20on%20GetConsoleWindow%20via%20PTY.md)← ## Detailed Description of the Pull Request / Additional comments - See the spec. It's pretty much everything I went through deciding on this. ## Validation Steps Performed - [x] Manual validation against scratch application calling all of the `::ShowWindow` commands against the pseudo console "fake window" and observing the real terminal window state --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:32:40 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29084
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?