Crash on About dialog when running Terminal unpackaged #2910

Closed
opened 2026-01-30 23:08:35 +00:00 by claunia · 5 comments
Owner

Originally created by @driver1998 on GitHub (Jul 24, 2019).

Originally assigned to: @zadjii-msft on GitHub.

Environment

Windows build number: [run "ver" at a command prompt] 10.0.18941.1001
Windows Terminal version (if applicable): commit 9d36b08b82c67c6965263c63bb83b024c15f3474

Any other software?

I know it is not a supported scenario, but with https://github.com/microsoft/terminal/pull/2043 we can now run Terminal unpackaged.
And some people might prefer it this way.

Steps to reproduce

Run WindowsTerminal.exe directly, outside of app package.
Click about in the drop down menu.

Expected behavior

The about dialog show up as normal.

Actual behavior

The app crashes.

Originally created by @driver1998 on GitHub (Jul 24, 2019). Originally assigned to: @zadjii-msft on GitHub. <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: [run "ver" at a command prompt] 10.0.18941.1001 Windows Terminal version (if applicable): commit 9d36b08b82c67c6965263c63bb83b024c15f3474 Any other software? ``` I know it is not a supported scenario, but with https://github.com/microsoft/terminal/pull/2043 we can now run Terminal unpackaged. And some people might prefer it this way. # Steps to reproduce Run WindowsTerminal.exe directly, outside of app package. Click about in the drop down menu. <!-- A description of how to trigger this bug. --> # Expected behavior The about dialog show up as normal. # Actual behavior The app crashes.
Author
Owner

@zadjii-msft commented on GitHub (Jul 24, 2019):

I'm going to chime in and say if #2043 made this work a little, I kinda want to make sure it keeps working. Before we went open-source, there was a time you could build and run the terminal from the commandline, using unpackaged activation like this. At some point it broke, and we just never had the time to investigate. If #2043 fixes launching, then I'm inclined to leave this open to track fixing this entirely.

@zadjii-msft commented on GitHub (Jul 24, 2019): I'm going to chime in and say if #2043 made this work a little, I kinda want to make sure it keeps working. Before we went open-source, there was a time you could build and run the terminal from the commandline, using unpackaged activation like this. At some point it broke, and we just never had the time to investigate. If #2043 fixes launching, then I'm inclined to leave this open to track fixing this entirely.
Author
Owner

@DHowett-MSFT commented on GitHub (Jul 24, 2019):

This actually also fails in the packaged version. 😄

@DHowett-MSFT commented on GitHub (Jul 24, 2019): This actually also fails in the packaged version. :smile:
Author
Owner

@zadjii-msft commented on GitHub (Jul 25, 2019):

I'm leaving a note to myself here: When the trying to run the terminal unpackaged, the resources.pri from CascadiaPackage is what you need. You can double-click WindowsTerminal.exe when you copy that file out of CascadiaPackage's output into bin\%ARCH%\%CONFIGURATION%, and launch the WindowsTerminal.exe in that folder. Running the WindowsTerminal.exe in the CascadiaPackage directory shockingly doesn't work.

However, I think we only build the resources.pri file if we build CascadiaPackage, so trying to only build WindowsTerminal then running it won't work. Hmmmm.

@zadjii-msft commented on GitHub (Jul 25, 2019): I'm leaving a note to myself here: When the trying to run the terminal unpackaged, the `resources.pri` from `CascadiaPackage` is what you need. You can double-click WindowsTerminal.exe when you copy that file out of CascadiaPackage's output into `bin\%ARCH%\%CONFIGURATION%`, and launch the WindowsTerminal.exe in that folder. Running the WindowsTerminal.exe in the CascadiaPackage directory shockingly doesn't work. However, I think we only build the resources.pri file if we build CascadiaPackage, so trying to _only_ build WindowsTerminal then running it won't work. Hmmmm.
Author
Owner

@zadjii-msft commented on GitHub (Jul 25, 2019):

This should maybe block v0.3. You can't open the about dialog at all, so we're going to get 100 dupes for this, and bug reports are going to become impossible to track.

  🌛
💪 💪
  👖
@zadjii-msft commented on GitHub (Jul 25, 2019): This should maybe block v0.3. You can't open the about dialog at all, so we're going to get 100 dupes for this, and bug reports are going to become impossible to track. ``` 🌛 💪 💪 👖 ```
Author
Owner

@zadjii-msft commented on GitHub (Jul 25, 2019):

So this seems to be related to the NavigateUri property on the Hyperlinks in the about dialog. If you remove those NavigateUri's, then it'll display just fine (but obviously not work).

Maybe we hack a workaround for now?

@zadjii-msft commented on GitHub (Jul 25, 2019): So this seems to be related to the `NavigateUri` property on the Hyperlinks in the about dialog. If you remove those `NavigateUri`'s, then it'll display just fine (but obviously not work). Maybe we hack a workaround for now?
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2910