[PR #12625] [MERGED] Fix showing a dialog multiple times #29142

Open
opened 2026-01-31 09:33:04 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12625
Author: @zadjii-msft
Created: 3/4/2022
Status: Merged
Merged: 3/10/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/12622-paste-paste


📝 Commits (4)

  • 43161ca Fix showing a dialog multiple times
  • f0bf880 oops this shouldn't be there
  • a0c5039 Merge remote-tracking branch 'origin/main' into dev/migrie/b/12622-paste-paste
  • 2879ec2 this is cleaner

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 src/cascadia/TerminalApp/AppLogic.cpp (+5 -1)

📄 Description

After the dialog is displayed, always clear it out. If we don't, we won't be able to display another!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12625 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 3/4/2022 **Status:** ✅ Merged **Merged:** 3/10/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/12622-paste-paste` --- ### 📝 Commits (4) - [`43161ca`](https://github.com/microsoft/terminal/commit/43161ca0d7ae4731d062ca65d551a2f20a1e63ad) Fix showing a dialog multiple times - [`f0bf880`](https://github.com/microsoft/terminal/commit/f0bf880c3ab722b6187b86196494c0e5879ce8f9) oops this shouldn't be there - [`a0c5039`](https://github.com/microsoft/terminal/commit/a0c5039b9585c6877213ade60f980cfcea68dd42) Merge remote-tracking branch 'origin/main' into dev/migrie/b/12622-paste-paste - [`2879ec2`](https://github.com/microsoft/terminal/commit/2879ec2373da1ce9d5f58d10315a664ffa19c7a5) this is cleaner ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/TerminalApp/AppLogic.cpp` (+5 -1) </details> ### 📄 Description After the dialog is displayed, always clear it out. If we don't, we won't be able to display another! * regressed in #12517. * [x] Fixes #12622. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:33:04 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29142