[PR #12669] Fix overflow in Viewport::FromDimensions #29175

Open
opened 2026-01-31 09:33:16 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/12669

State: closed
Merged: Yes


This removes one source of potential integer overflows from the Viewport class.
Other parts were left untouched, as this entire class of overflow issues gets
fixed all at once, as soon as we replace COORD with til::coord (etc.).

PR Checklist

Validation Steps Performed

  • Call ScrollConsoleScreenBufferW with out of bounds coordinates
  • Doesn't crash ✅
**Original Pull Request:** https://github.com/microsoft/terminal/pull/12669 **State:** closed **Merged:** Yes --- This removes one source of potential integer overflows from the Viewport class. Other parts were left untouched, as this entire class of overflow issues gets fixed all at once, as soon as we replace COORD with til::coord (etc.). ## PR Checklist * [x] Closes #5271 * [x] I work here * [x] Tests added/passed ## Validation Steps Performed * Call `ScrollConsoleScreenBufferW` with out of bounds coordinates * Doesn't crash ✅
claunia added the pull-request label 2026-01-31 09:33:16 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29175