Resolve longstanding issues with conhost's MeasureRight #2919

Closed
opened 2026-01-30 23:08:46 +00:00 by claunia · 5 comments
Owner

Originally created by @BladeMF on GitHub (Jul 25, 2019).

Originally assigned to: @miniksa on GitHub.

Environment

Windows build number: Version 10.0.18362.239
Windows Terminal version (if applicable):0.2.1831.0

Symfony 4.3

Steps to reproduce

Render a block with background color after the text. The used command is from Symfony 4.3. I can provide instructions or find the exact control codes that were used if needed.

Expected behavior

A solid block of background color. The screenshot is from cmd.

image

Actual behavior

The background color ends after the text.

image

Originally created by @BladeMF on GitHub (Jul 25, 2019). Originally assigned to: @miniksa on GitHub. <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: Version 10.0.18362.239 Windows Terminal version (if applicable):0.2.1831.0 Symfony 4.3 ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> Render a block with background color after the text. The used command is from Symfony 4.3. I can provide instructions or find the exact control codes that were used if needed. # Expected behavior A solid block of background color. The screenshot is from cmd. ![image](https://user-images.githubusercontent.com/12109622/61876774-4d163680-aef6-11e9-8cb6-eef0265530c0.png) # Actual behavior The background color ends after the text. ![image](https://user-images.githubusercontent.com/12109622/61876748-3cfe5700-aef6-11e9-9625-e86fbc63af85.png)
Author
Owner

@DHowett-MSFT commented on GitHub (Jul 29, 2019):

Congrats, this is now the "Kill MeasureRight" (it'll make sense later) issue. The heart of the issue is that conhost can occasionally not tell whether the spaces that are in the buffer were on purpose or not. 🤷‍♀

@DHowett-MSFT commented on GitHub (Jul 29, 2019): Congrats, this is now the "Kill MeasureRight" (it'll make sense later) issue. The heart of the issue is that conhost can occasionally not tell whether the spaces that are in the buffer were on purpose or not. 🤷‍♀
Author
Owner

@BladeMF commented on GitHub (Aug 6, 2019):

More examples (hopefuly useful):
image
See how "Success!" is OK, but "Application Migration" isn't? Not sure what that means.

@BladeMF commented on GitHub (Aug 6, 2019): More examples (hopefuly useful): ![image](https://user-images.githubusercontent.com/12109622/62536702-4ae99b80-b857-11e9-9304-82bbaebc2848.png) See how "Success!" is OK, but "Application Migration" isn't? Not sure what that means.
Author
Owner

@DHowett-MSFT commented on GitHub (Feb 21, 2020):

I hacked at making MeasureRight care about attributes, and while it was slow it felt like it did the right thing.

@DHowett-MSFT commented on GitHub (Feb 21, 2020): I hacked at making MeasureRight care about attributes, and while it was slow it felt like it did the right thing.
Author
Owner

@zadjii-msft commented on GitHub (Dec 6, 2021):

Huh, this is /dup #32, and more broadly, we're tracking this in #8000.

@zadjii-msft commented on GitHub (Dec 6, 2021): Huh, this is /dup #32, and more broadly, we're tracking this in #8000.
Author
Owner

@ghost commented on GitHub (Dec 6, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Dec 6, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2919