[PR #12713] Fix engine size not being changed on DPI changes #29207

Open
opened 2026-01-31 09:33:29 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/12713

State: closed
Merged: Yes


Previously we would only call SetWindowSize and TriggerRedrawAll if the
viewport size in characters changed. This commit removes the limitation.
Since the if-condition limiting full redraws is now gone, this commit
moves the responsibility of limiting the calls up the call chain.
With _refreshSizeUnderLock now being a heavier function call
than before, some surrounding code was thus refactored.

PR Checklist

Validation Steps Performed

Test relevant for #11317:

  • Print text, filling the entire window
  • Move the window from a 150% scale to a 300% scale monitor
  • The application works as expected ✅

Regression tests:

  • Text zoom with Ctrl+Plus/Minus/0 works as before ✅
  • Resizing a window works as before ✅
  • No deadlocks, etc. during settings updates ✅
**Original Pull Request:** https://github.com/microsoft/terminal/pull/12713 **State:** closed **Merged:** Yes --- Previously we would only call `SetWindowSize` and `TriggerRedrawAll` if the viewport size in characters changed. This commit removes the limitation. Since the if-condition limiting full redraws is now gone, this commit moves the responsibility of limiting the calls up the call chain. With `_refreshSizeUnderLock` now being a heavier function call than before, some surrounding code was thus refactored. ## PR Checklist * [x] Closes #11317 * [x] I work here * [x] Tests added/passed ## Validation Steps Performed Test relevant for #11317: * Print text, filling the entire window * Move the window from a 150% scale to a 300% scale monitor * The application works as expected ✅ Regression tests: * Text zoom with Ctrl+Plus/Minus/0 works as before ✅ * Resizing a window works as before ✅ * No deadlocks, etc. during settings updates ✅
claunia added the pull-request label 2026-01-31 09:33:29 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29207