[PR #12819] [MERGED] Force the bundle major version to be over 3000 #29240

Open
opened 2026-01-31 09:33:41 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12819
Author: @DHowett
Created: 4/4/2022
Status: ✅ Merged
Merged: 4/4/2022
Merged by: @undefined

Base: main ← Head: dev/duhowett/over-three-THOUSAND


📝 Commits (5)

  • ebdc30d Force the bundle major version to be over 3000
  • 783df53 ffs
  • a27ff31 NFCI: Disable loc since it seems broken today???
  • 2ebd044 Lol OK
  • b82c38a Revert "NFCI: Disable loc since it seems broken today???"

📊 Changes

1 file changed (+9 additions, -4 deletions)

View changed files

📝 build/pipelines/release.yml (+9 -4)

📄 Description

Before #12691, the msixbundle version was of the format YYYY.MM.DD.0.
After #12691, it became the same as the build of Terminal it contained.

This caused some trouble for some systems: major version 1 is much,
much smaller than 2022.

Adding 3000 to the major version component, only for the bundle, gets
around this. Ugh.

Fixes #12816.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12819 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 4/4/2022 **Status:** ✅ Merged **Merged:** 4/4/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/duhowett/over-three-THOUSAND` --- ### 📝 Commits (5) - [`ebdc30d`](https://github.com/microsoft/terminal/commit/ebdc30d99153c0680d9a444490bd478023877caf) Force the bundle major version to be over 3000 - [`783df53`](https://github.com/microsoft/terminal/commit/783df530bef0760e1e83768b1651fad84753079e) ffs - [`a27ff31`](https://github.com/microsoft/terminal/commit/a27ff3124c69d8e519555d671e1b01c4338e78a8) NFCI: Disable loc since it seems broken today??? - [`2ebd044`](https://github.com/microsoft/terminal/commit/2ebd0443dcf11031002aa35c0072281c54e74d98) Lol OK - [`b82c38a`](https://github.com/microsoft/terminal/commit/b82c38aca063b9ae45e8d359681743745cfdec7f) Revert "NFCI: Disable loc since it seems broken today???" ### 📊 Changes **1 file changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `build/pipelines/release.yml` (+9 -4) </details> ### 📄 Description Before #12691, the msixbundle version was of the format YYYY.MM.DD.0. After #12691, it became the same as the build of Terminal it contained. This caused some trouble for _some_ systems: major version 1 is much, much smaller than 2022. Adding 3000 to the major version component, _only for the bundle_, gets around this. Ugh. Fixes #12816. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:33:42 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29240