starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[PR #12835] [MERGED] Spelling / Grammar #29262

New Issue
Open
opened 2026-01-31 09:33:49 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 09:33:49 +00:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12835
Author: @jsoref
Created: 4/6/2022
Status: ✅ Merged
Merged: 4/6/2022
Merged by: @undefined

Base: main ← Head: spelling

📝 Commits (10+)

📊 Changes

17 files changed (+23 additions, -23 deletions)

View changed files

📝 doc/specs/#1790 - Font features and axes-spec.md (+1 -1)
📝 doc/specs/#5000 - Process Model 2.0/#1032 - Elevation Quality of Life Improvements.md (+2 -2)
📝 doc/specs/#5000 - Process Model 2.0/#5000 - Process Model 2.0.md (+1 -1)
📝 doc/specs/#607 - Commandline Arguments for the Windows Terminal.md (+1 -1)
📝 src/buffer/out/AttrRow.cpp (+1 -1)
📝 src/cascadia/TerminalApp/Pane.cpp (+2 -2)
📝 src/cascadia/TerminalApp/TabManagement.cpp (+1 -1)
📝 src/cascadia/TerminalCore/TerminalApi.cpp (+1 -1)
📝 src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp (+1 -1)
📝 src/host/CopyFromCharPopup.cpp (+1 -1)
📝 src/host/exe/CConsoleHandoff.cpp (+1 -1)
📝 src/host/ft_host/API_TitleTests.cpp (+4 -4)
📝 src/host/ft_host/Message_KeyPressTests.cpp (+1 -1)
📝 src/host/ft_uia/AccessibilityTests.cs (+1 -1)
📝 src/host/settings.cpp (+1 -1)
📝 src/host/ut_host/ScreenBufferTests.cpp (+2 -2)
📝 src/renderer/dx/CustomTextRenderer.cpp (+1 -1)

📄 Description

Mostly this is dropping doubled words. There's one brand fix.

Detailed Description of the Pull Request / Additional comments

I'm close to shipping an upgrade to check-spelling, but in testing it against this repository, I see one behavior change that I'd like to resolve. So, while I try to figure out how, I figured I'd at least leave the fixes submitted.

(I have some ideas, as I've been slowly working towards a solution to this problem, but it isn't a simple one line change.)

Validation Steps Performed

Ran check-spelling v0.0.20-alpha5 w/ a refresh of the configuration based on https://github.com/check-spelling/spell-check-this/tree/prerelease/.github/workflows/

(It identified one minor bug which is fixed in 0.0.20-alpha6 - unreleased.)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12835 **Author:** [@jsoref](https://github.com/jsoref) **Created:** 4/6/2022 **Status:** ✅ Merged **Merged:** 4/6/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `spelling` --- ### 📝 Commits (10+) - [`8409496`](https://github.com/microsoft/terminal/commit/840949683a1557e5a17f45064dda2016f0080d1e) spelling: and - [`0a96019`](https://github.com/microsoft/terminal/commit/0a960197b0f4418c81f2d0c7cf1848eea668ebf7) spelling: are - [`cea3f57`](https://github.com/microsoft/terminal/commit/cea3f572af147cfed693188ff5150c1a5cd2aeca) spelling: char - [`213665c`](https://github.com/microsoft/terminal/commit/213665c6600706358e3d8cc917760f0556c36bbb) spelling: endpoint - [`bee5fd7`](https://github.com/microsoft/terminal/commit/bee5fd7336c2ec0011bc2251f014ca66d91f2df9) spelling: from - [`c8fca58`](https://github.com/microsoft/terminal/commit/c8fca58d713b3bfd16512c447e984127032b9633) spelling: github - [`e90b06e`](https://github.com/microsoft/terminal/commit/e90b06ea5c67de5c75c44891710c6d73d16e83f3) spelling: have - [`37e64dc`](https://github.com/microsoft/terminal/commit/37e64dc7302c34e5c4d87e4d8faafc1dd43902f6) spelling: size - [`e804f3c`](https://github.com/microsoft/terminal/commit/e804f3c2d3580ff58d96168a3a03fe326b15c9cd) spelling: the - [`34cd750`](https://github.com/microsoft/terminal/commit/34cd750b78d20438275c4e6986e4f00f345c9784) spelling: want ### 📊 Changes **17 files changed** (+23 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `doc/specs/#1790 - Font features and axes-spec.md` (+1 -1) 📝 `doc/specs/#5000 - Process Model 2.0/#1032 - Elevation Quality of Life Improvements.md` (+2 -2) 📝 `doc/specs/#5000 - Process Model 2.0/#5000 - Process Model 2.0.md` (+1 -1) 📝 `doc/specs/#607 - Commandline Arguments for the Windows Terminal.md` (+1 -1) 📝 `src/buffer/out/AttrRow.cpp` (+1 -1) 📝 `src/cascadia/TerminalApp/Pane.cpp` (+2 -2) 📝 `src/cascadia/TerminalApp/TabManagement.cpp` (+1 -1) 📝 `src/cascadia/TerminalCore/TerminalApi.cpp` (+1 -1) 📝 `src/cascadia/WindowsTerminal/NonClientIslandWindow.cpp` (+1 -1) 📝 `src/host/CopyFromCharPopup.cpp` (+1 -1) 📝 `src/host/exe/CConsoleHandoff.cpp` (+1 -1) 📝 `src/host/ft_host/API_TitleTests.cpp` (+4 -4) 📝 `src/host/ft_host/Message_KeyPressTests.cpp` (+1 -1) 📝 `src/host/ft_uia/AccessibilityTests.cs` (+1 -1) 📝 `src/host/settings.cpp` (+1 -1) 📝 `src/host/ut_host/ScreenBufferTests.cpp` (+2 -2) 📝 `src/renderer/dx/CustomTextRenderer.cpp` (+1 -1) </details> ### 📄 Description Mostly this is dropping doubled words. There's one brand fix. ## Detailed Description of the Pull Request / Additional comments I'm close to shipping an [upgrade to check-spelling](https://github.com/check-spelling/check-spelling/releases/tag/v0.0.20-alpha5), but in testing it against this repository, I see one behavior change that I'd like to resolve. So, while I try to figure out how, I figured I'd at least leave the fixes submitted. (I have some ideas, as I've been slowly working towards a solution to this problem, but it isn't a simple one line change.) ## Validation Steps Performed [Ran check-spelling v0.0.20-alpha5](https://github.com/check-spelling/terminal/actions/runs/2100515961) w/ a refresh of the configuration based on https://github.com/check-spelling/spell-check-this/tree/prerelease/.github/workflows/ (It identified one minor bug which is fixed in 0.0.20-alpha6 - unreleased.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:33:49 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29262
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?