[PR #12838] [MERGED] Crash on launch - Cache ProposeCommandlineResult locally #29264

Open
opened 2026-01-31 09:33:49 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12838
Author: @zadjii-msft
Created: 4/6/2022
Status: ✅ Merged
Merged: 4/6/2022
Merged by: @undefined

Base: main ← Head: dev/migrie/b/handle-THIS


📝 Commits (3)

  • 9dc0324 I think this fixes it
  • 80bdcff fix this because it's been bothering me for months
  • 3a5368c a smaller diff

📊 Changes

3 files changed (+20 additions, -2 deletions)

View changed files

📝 src/cascadia/Remoting/ProposeCommandlineResult.h (+5 -0)
📝 src/cascadia/Remoting/SummonWindowBehavior.h (+5 -1)
📝 src/cascadia/Remoting/WindowManager.cpp (+10 -1)

📄 Description

This is like, 2-4% of our crashes. Impossible to say for sure, but this looks like it's the root cause. This is just another one of our HandleCommandlineArgs buckets, hopefully the last.

  • Hopefully should close out MSFT:38542548
  • No I didn't write tests, impossible to test
  • it builds

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12838 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/6/2022 **Status:** ✅ Merged **Merged:** 4/6/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/handle-THIS` --- ### 📝 Commits (3) - [`9dc0324`](https://github.com/microsoft/terminal/commit/9dc032414b4afb35f3caf81ece30e496ece299e2) I think this fixes it - [`80bdcff`](https://github.com/microsoft/terminal/commit/80bdcfffbb18fffe430ce9f3e76df8247402d7cf) fix this because it's been bothering me for months - [`3a5368c`](https://github.com/microsoft/terminal/commit/3a5368c0c13a79ad4d837c0537bef037fa62c868) a smaller diff ### 📊 Changes **3 files changed** (+20 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/Remoting/ProposeCommandlineResult.h` (+5 -0) 📝 `src/cascadia/Remoting/SummonWindowBehavior.h` (+5 -1) 📝 `src/cascadia/Remoting/WindowManager.cpp` (+10 -1) </details> ### 📄 Description This is like, 2-4% of our crashes. Impossible to say for sure, but this _looks_ like it's the root cause. This is just another one of our `HandleCommandlineArgs` buckets, hopefully the last. * [x] Hopefully should close out MSFT:38542548 * [ ] No I didn't write tests, impossible to test * [x] it builds --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:33:49 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29264