[PR #12856] [MERGED] Remove default_interface from Monarch #29281

Open
opened 2026-01-31 09:33:57 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12856
Author: @zadjii-msft
Created: 4/8/2022
Status: ✅ Merged
Merged: 4/8/2022
Merged by: @DHowett

Base: main ← Head: dev/migrie/b/12774-this-is-no-ordinary-darkness


📝 Commits (2)

📊 Changes

3 files changed (+4 additions, -4 deletions)

View changed files

📝 src/cascadia/Remoting/Monarch.idl (+1 -1)
📝 src/cascadia/Remoting/WindowManager.cpp (+2 -2)
📝 src/cascadia/Remoting/WindowManager.h (+1 -1)

📄 Description

This is all of course, conjecture. This crash is totally wild and makes no sense at all. But, we're hoping that this fixes it. This should also make calls to the Monarch a little easier.

You may be asking yourself - why aren't I doing this for the Peasant too? Well, because the Peasant simply doesn't crash like the monarch does. I'm not gonna touch something that's not broken during ask mode.

  • Closes #12774, hopefully.
  • tests pass.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12856 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/8/2022 **Status:** ✅ Merged **Merged:** 4/8/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/migrie/b/12774-this-is-no-ordinary-darkness` --- ### 📝 Commits (2) - [`b2a3e1b`](https://github.com/microsoft/terminal/commit/b2a3e1b6fb933038e9efd84777b2871963c96736) Remove `default_interface` from Monarch - [`6c2e860`](https://github.com/microsoft/terminal/commit/6c2e8609deb715c7b8e706aaad1845387e0b369d) okay ### 📊 Changes **3 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/Remoting/Monarch.idl` (+1 -1) 📝 `src/cascadia/Remoting/WindowManager.cpp` (+2 -2) 📝 `src/cascadia/Remoting/WindowManager.h` (+1 -1) </details> ### 📄 Description This is all of course, conjecture. This crash is totally wild and makes no sense at all. But, we're hoping that this fixes it. This should also make calls to the Monarch a little easier. You may be asking yourself - why aren't I doing this for the Peasant too? Well, because the Peasant simply doesn't crash like the monarch does. I'm not gonna touch something that's not broken _during ask mode_. * [x] Closes #12774, hopefully. * [x] tests pass. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:33:57 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29281