[PR #12910] [MERGED] Add support for rich code navigation in GitHub, redux #29301

Open
opened 2026-01-31 09:34:06 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12910
Author: @zadjii-msft
Created: 4/15/2022
Status: ✅ Merged
Merged: 4/18/2022
Merged by: @DHowett

Base: main ← Head: dev/migrie/ci/gh-codenav


📝 Commits (9)

  • 29bcb1a this is a test
  • 8ca2ae6 I literally am incapable of spelling
  • d141ecc Merge remote-tracking branch 'origin/main' into dev/migrie/ci/gh-codenav
  • ce3619e This should add the debugging tool?
  • 4b69991 this step might be important
  • d23e51d Merge remote-tracking branch 'origin/main' into dev/migrie/ci/gh-codenav
  • fe8e173 disable code index on PRs
  • e7d4642 this time, I won't break the entire CI
  • a89d1a6 and(succeeded()) too

📊 Changes

3 files changed (+30 additions, -0 deletions)

View changed files

📝 build/pipelines/ci.yml (+7 -0)
📝 build/pipelines/templates/build-console-ci.yml (+1 -0)
➕ build/pipelines/templates/codenav-indexer.yml (+22 -0)

📄 Description

This is exactly the same as #12855, save for one small difference:

diff --git a/build/pipelines/ci.yml b/build/pipelines/ci.yml
index e4e53e9b2..dc9040aeb 100644
--- a/build/pipelines/ci.yml
+++ b/build/pipelines/ci.yml
@@ -99,7 +99,6 @@ stages:
   - stage: CodeIndexer
     displayName: Github CodeNav Indexer
     dependsOn: [Build_x64]
-    condition: succeeded()
+    condition: and(succeeded(), not(eq(variables['Build.Reason'], 'PullRequest')))
     jobs:
       - template: ./templates/codenav-indexer.yml
-    condition: not(eq(variables['Build.Reason'], 'PullRequest'))

Because the first ones failed with
image

And that hosed the whole CI


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12910 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/15/2022 **Status:** ✅ Merged **Merged:** 4/18/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/migrie/ci/gh-codenav` --- ### 📝 Commits (9) - [`29bcb1a`](https://github.com/microsoft/terminal/commit/29bcb1a8dfbf80dae888c93d9e6a04f22ab8c7dd) this is a test - [`8ca2ae6`](https://github.com/microsoft/terminal/commit/8ca2ae6885b782f32e40e787217d0fd9a1f45cf4) I literally am incapable of spelling - [`d141ecc`](https://github.com/microsoft/terminal/commit/d141eccbb3b382cedf75cd44692380c0758add2e) Merge remote-tracking branch 'origin/main' into dev/migrie/ci/gh-codenav - [`ce3619e`](https://github.com/microsoft/terminal/commit/ce3619e98da79f47344471644cbf542009468560) This should add the debugging tool? - [`4b69991`](https://github.com/microsoft/terminal/commit/4b69991ff108adcb1bf60f0df1fbee48073a12c5) this step might be important - [`d23e51d`](https://github.com/microsoft/terminal/commit/d23e51d1123c26a6baa4c157375df817e752ccb5) Merge remote-tracking branch 'origin/main' into dev/migrie/ci/gh-codenav - [`fe8e173`](https://github.com/microsoft/terminal/commit/fe8e1736dc961285de6ad6a6204926f74b490cbe) disable code index on PRs - [`e7d4642`](https://github.com/microsoft/terminal/commit/e7d46427db2db2f48f626205994bf3cbbf0f7acd) this time, I won't break the entire CI - [`a89d1a6`](https://github.com/microsoft/terminal/commit/a89d1a63f39bcd7320dec9d1090c36b81c6ce9f8) and(succeeded()) too ### 📊 Changes **3 files changed** (+30 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `build/pipelines/ci.yml` (+7 -0) 📝 `build/pipelines/templates/build-console-ci.yml` (+1 -0) ➕ `build/pipelines/templates/codenav-indexer.yml` (+22 -0) </details> ### 📄 Description This is exactly the same as #12855, save for one small difference: ```diff diff --git a/build/pipelines/ci.yml b/build/pipelines/ci.yml index e4e53e9b2..dc9040aeb 100644 --- a/build/pipelines/ci.yml +++ b/build/pipelines/ci.yml @@ -99,7 +99,6 @@ stages: - stage: CodeIndexer displayName: Github CodeNav Indexer dependsOn: [Build_x64] - condition: succeeded() + condition: and(succeeded(), not(eq(variables['Build.Reason'], 'PullRequest'))) jobs: - template: ./templates/codenav-indexer.yml - condition: not(eq(variables['Build.Reason'], 'PullRequest')) ``` Because the first ones failed with ![image](https://user-images.githubusercontent.com/18356694/163560825-0600315e-914e-4673-9f28-407436f58758.png) And that hosed the whole CI --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:06 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29301