[PR #12910] Add support for rich code navigation in GitHub, redux #29306

Closed
opened 2026-01-31 09:34:08 +00:00 by claunia · 0 comments
Owner

Original Pull Request: https://github.com/microsoft/terminal/pull/12910

State: closed
Merged: Yes


This is exactly the same as #12855, save for one small difference:

diff --git a/build/pipelines/ci.yml b/build/pipelines/ci.yml
index e4e53e9b2..dc9040aeb 100644
--- a/build/pipelines/ci.yml
+++ b/build/pipelines/ci.yml
@@ -99,7 +99,6 @@ stages:
   - stage: CodeIndexer
     displayName: Github CodeNav Indexer
     dependsOn: [Build_x64]
-    condition: succeeded()
+    condition: and(succeeded(), not(eq(variables['Build.Reason'], 'PullRequest')))
     jobs:
       - template: ./templates/codenav-indexer.yml
-    condition: not(eq(variables['Build.Reason'], 'PullRequest'))

Because the first ones failed with
image

And that hosed the whole CI

**Original Pull Request:** https://github.com/microsoft/terminal/pull/12910 **State:** closed **Merged:** Yes --- This is exactly the same as #12855, save for one small difference: ```diff diff --git a/build/pipelines/ci.yml b/build/pipelines/ci.yml index e4e53e9b2..dc9040aeb 100644 --- a/build/pipelines/ci.yml +++ b/build/pipelines/ci.yml @@ -99,7 +99,6 @@ stages: - stage: CodeIndexer displayName: Github CodeNav Indexer dependsOn: [Build_x64] - condition: succeeded() + condition: and(succeeded(), not(eq(variables['Build.Reason'], 'PullRequest'))) jobs: - template: ./templates/codenav-indexer.yml - condition: not(eq(variables['Build.Reason'], 'PullRequest')) ``` Because the first ones failed with ![image](https://user-images.githubusercontent.com/18356694/163560825-0600315e-914e-4673-9f28-407436f58758.png) And that hosed the whole CI
claunia added the pull-request label 2026-01-31 09:34:08 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29306