TerminalApp.Unit.Tests should have its SxS manifest auto-generated like WindowsTerminal #2931

Closed
opened 2026-01-30 23:09:05 +00:00 by claunia · 3 comments
Owner

Originally created by @zadjii-msft on GitHub (Jul 25, 2019).

I'm not sure why, but the bcz build itself seems to keep changing this file. Should I leave the changes? They seem similar to changes that were manually done in PR #2043 so I hope they're not bad.

Originally posted by @metathinker in https://github.com/microsoft/terminal/pull/2050/files

Since WindowsTerminal.manifest is empty now, and auto-generated, we'll need to also auto-generate the manifest for the tests for SxS WinRT activation.

Originally created by @zadjii-msft on GitHub (Jul 25, 2019). > I'm not sure why, but the `bcz` build itself seems to keep changing this file. Should I leave the changes? They seem similar to changes that were manually done in PR #2043 so I hope they're not bad. _Originally posted by @metathinker in https://github.com/microsoft/terminal/pull/2050/files_ Since WindowsTerminal.manifest is empty now, and auto-generated, we'll need to also auto-generate the manifest for the tests for SxS WinRT activation.
claunia added the Help WantedIssue-TaskNeeds-Tag-FixProduct-TerminalArea-Build labels 2026-01-30 23:09:05 +00:00
Author
Owner

@zadjii-msft commented on GitHub (Jul 25, 2019):

This is also related to #1210.

This matters for the "SettingsTests".

@zadjii-msft commented on GitHub (Jul 25, 2019): This is also related to #1210. This matters for the "SettingsTests".
Author
Owner

@zadjii-msft commented on GitHub (Aug 16, 2019):

This should have honestly been done at the same time as #2294. The stuff that the LocalTests project does is exactly what this issue is talking about doing.

@zadjii-msft commented on GitHub (Aug 16, 2019): This should have honestly been done at the same time as #2294. The stuff that the LocalTests project does is _exactly_ what this issue is talking about doing.
Author
Owner

@zadjii-msft commented on GitHub (Jan 23, 2020):

Hey I did this with #4105! Or more correctly, we don't need to do this anymore, now that the localtests are magic.

@zadjii-msft commented on GitHub (Jan 23, 2020): Hey I did this with #4105! Or more correctly, we don't need to do this anymore, now that the localtests are magic.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#2931