[PR #12984] [MERGED] Exclude the NuGet prerelease suffix in branded release-* builds #29318

Open
opened 2026-01-31 09:34:13 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12984
Author: @DHowett
Created: 4/26/2022
Status: ✅ Merged
Merged: 4/27/2022
Merged by: @DHowett

Base: main ← Head: dev/duhowett/verp


📝 Commits (5)

  • a017cd4 Disable the inclusion of the branch name in our NuGet packages
  • 1928847 Actually, be even smarter
  • 9a2136c Right variable
  • 9bbd6fa this is silly
  • c72e149 oh i think this is it

📊 Changes

1 file changed (+15 additions, -0 deletions)

View changed files

📝 build/pipelines/release.yml (+15 -0)

📄 Description

If we are building a branch called "release-*", we will also change the
NuGet suffix to "preview". If we don't do that, XES will set the suffix
to "release1" because it truncates the value after the first period. In
general, though, we want to disable the suffix entirely if we're Release
branded while on a release branch.

In effect:

BRANCH / BRANDING Release Preview
release-* 1.12.20220427 1.13.20220427-preview
all others 1.14.20220427-mybranch 1.14.20220427-mybranch

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12984 **Author:** [@DHowett](https://github.com/DHowett) **Created:** 4/26/2022 **Status:** ✅ Merged **Merged:** 4/27/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/duhowett/verp` --- ### 📝 Commits (5) - [`a017cd4`](https://github.com/microsoft/terminal/commit/a017cd40ed3c70974c7b50d9b8aa73a0b3b303b9) Disable the inclusion of the branch name in our NuGet packages - [`1928847`](https://github.com/microsoft/terminal/commit/1928847abf0156c1d7eba284a24cbc5c74042edb) Actually, be even smarter - [`9a2136c`](https://github.com/microsoft/terminal/commit/9a2136c23c98934dfc0b68f1abf1deabe34e55ed) Right variable - [`9bbd6fa`](https://github.com/microsoft/terminal/commit/9bbd6fa3fca9ea8da9784f7531f3acf75a767cfd) this is silly - [`c72e149`](https://github.com/microsoft/terminal/commit/c72e149a54f2eaa08d16a990b40a08fd66fdb732) oh i think this is it ### 📊 Changes **1 file changed** (+15 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `build/pipelines/release.yml` (+15 -0) </details> ### 📄 Description If we are building a branch called "release-*", we will also change the NuGet suffix to "preview". If we don't do that, XES will set the suffix to "release1" because it truncates the value after the first period. In general, though, we want to disable the suffix entirely if we're Release branded while on a release branch. In effect: BRANCH / BRANDING | Release | Preview ------------------|------------------------|------------------------ release-* | 1.12.20220427 | 1.13.20220427-preview all others | 1.14.20220427-mybranch | 1.14.20220427-mybranch --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:13 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29318