[PR #12997] [MERGED] Fix the TabTests, April 2022 edition #29319

Open
opened 2026-01-31 09:34:13 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/12997
Author: @zadjii-msft
Created: 4/28/2022
Status: ✅ Merged
Merged: 5/5/2022
Merged by: @undefined

Base: main ← Head: dev/migrie/b/12158-tab-tests-april-2022


📝 Commits (4)

  • 0f8e050 this fixes the tests, but the conhosts all crash in ucrtbase. Gotta figure that out.
  • 7a2f9fa fix remaining issues
  • 48ab0f2 cleanup from review
  • fd65089 Merge remote-tracking branch 'origin/main' into dev/migrie/b/12158-tab-tests-april-2022

📊 Changes

4 files changed (+44 additions, -30 deletions)

View changed files

📝 src/cascadia/LocalTests_TerminalApp/TabTests.cpp (+8 -2)
📝 src/cascadia/TerminalApp/ActionPreviewHandlers.cpp (+28 -27)
📝 src/cascadia/TerminalApp/TerminalPage.cpp (+6 -0)
📝 src/cascadia/TerminalApp/TerminalPage.h (+2 -1)

📄 Description

In classic fashion, we never run the LocalTests locally before committing, so stuff breaks from time to time.

This time, the main trick was that the tests had a pretty hardcore dependency on the inner workings of _PreviewActionHandler, and when that changed, they broke.

Also, there was a weird crash I saw when I had the default terminal set to the Dev build version. That crash would let the test contents pass, but ultimately fail when TAEF tore down the conhost. Unsetting that fixed the crash 🤷

Closes #12158


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/12997 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/28/2022 **Status:** ✅ Merged **Merged:** 5/5/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/12158-tab-tests-april-2022` --- ### 📝 Commits (4) - [`0f8e050`](https://github.com/microsoft/terminal/commit/0f8e0501d1bd12506c7269139b8aba3286f15d5b) this fixes the tests, but the conhosts all crash in ucrtbase. Gotta figure that out. - [`7a2f9fa`](https://github.com/microsoft/terminal/commit/7a2f9fa427ca630de25a5e5161876435ef04f7a0) fix remaining issues - [`48ab0f2`](https://github.com/microsoft/terminal/commit/48ab0f2ac394d45fe796a14ce2bd132855925b69) cleanup from review - [`fd65089`](https://github.com/microsoft/terminal/commit/fd6508911c9f6943204de9df7c47d10872557f0c) Merge remote-tracking branch 'origin/main' into dev/migrie/b/12158-tab-tests-april-2022 ### 📊 Changes **4 files changed** (+44 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/cascadia/LocalTests_TerminalApp/TabTests.cpp` (+8 -2) 📝 `src/cascadia/TerminalApp/ActionPreviewHandlers.cpp` (+28 -27) 📝 `src/cascadia/TerminalApp/TerminalPage.cpp` (+6 -0) 📝 `src/cascadia/TerminalApp/TerminalPage.h` (+2 -1) </details> ### 📄 Description In classic fashion, we never run the LocalTests locally before committing, so stuff breaks from time to time. This time, the main trick was that the tests had a pretty hardcore dependency on the inner workings of `_PreviewActionHandler`, and when that changed, they broke. Also, there was a weird crash I saw when I had the default terminal set to the Dev build version. That crash would let the test contents pass, but ultimately fail when TAEF tore down the conhost. Unsetting that fixed the crash 🤷 Closes #12158 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:13 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29319