[PR #13001] [MERGED] Fix a crash when resizing conhost in Debug #29331

Open
opened 2026-01-31 09:34:17 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13001
Author: @zadjii-msft
Created: 4/29/2022
Status: Merged
Merged: 4/29/2022
Merged by: @DHowett

Base: mainHead: dev/migrie/b/12917-clamp


📝 Commits (1)

  • 0a8b3e1 Fix a crash when resizind conhost in Debug

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 src/renderer/base/renderer.cpp (+1 -3)

📄 Description

Don't clamp here, it's unnecessary. See notes in https://github.com/microsoft/terminal/issues/12917#issuecomment-1101423091

Closes #12917


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13001 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 4/29/2022 **Status:** ✅ Merged **Merged:** 4/29/2022 **Merged by:** [@DHowett](https://github.com/DHowett) **Base:** `main` ← **Head:** `dev/migrie/b/12917-clamp` --- ### 📝 Commits (1) - [`0a8b3e1`](https://github.com/microsoft/terminal/commit/0a8b3e13c6be9efe3d33026ac4f92a206f589e8a) Fix a crash when resizind conhost in Debug ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/renderer/base/renderer.cpp` (+1 -3) </details> ### 📄 Description Don't clamp here, it's unnecessary. See notes in https://github.com/microsoft/terminal/issues/12917#issuecomment-1101423091 Closes #12917 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:17 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29331