[PR #13044] [MERGED] Only add the ProfileVM.DeleteProfile handler once #29344

Open
opened 2026-01-31 09:34:22 +00:00 by claunia · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/microsoft/terminal/pull/13044
Author: @zadjii-msft
Created: 5/5/2022
Status: Merged
Merged: 5/6/2022
Merged by: @undefined

Base: mainHead: dev/migrie/b/13017-delete-profiles-makes-boom


📝 Commits (2)

📊 Changes

2 files changed (+5 additions, -3 deletions)

View changed files

📝 .github/actions/spelling/allow/allow.txt (+1 -0)
📝 src/cascadia/TerminalSettingsEditor/MainPage.cpp (+4 -3)

📄 Description

Turns out if you add that Delete handler there, then every time you navigate to the profile, we'll add another Delete handler to the list of handlers. That's bad - that'll cause us to try and delete the profile multiple times.

The repro I had before was 100%, now it's fixed.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/microsoft/terminal/pull/13044 **Author:** [@zadjii-msft](https://github.com/zadjii-msft) **Created:** 5/5/2022 **Status:** ✅ Merged **Merged:** 5/6/2022 **Merged by:** [@undefined](undefined) **Base:** `main` ← **Head:** `dev/migrie/b/13017-delete-profiles-makes-boom` --- ### 📝 Commits (2) - [`eea14e3`](https://github.com/microsoft/terminal/commit/eea14e308b301620498f33c5b9d3631330e3b874) fixes #13017 - [`226022c`](https://github.com/microsoft/terminal/commit/226022c8438ecb37107dac8d21c99c99df8e713a) no one notice me sneaking this ### 📊 Changes **2 files changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `.github/actions/spelling/allow/allow.txt` (+1 -0) 📝 `src/cascadia/TerminalSettingsEditor/MainPage.cpp` (+4 -3) </details> ### 📄 Description Turns out if you add that Delete handler there, then every time you navigate to the profile, we'll add another Delete handler to the list of handlers. That's bad - that'll cause us to try and delete the profile multiple times. The repro I had before was 100%, now it's fixed. * [x] Closes #13017 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
claunia added the pull-request label 2026-01-31 09:34:22 +00:00
Sign in to join this conversation.
No Label pull-request
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#29344